Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Backport 2.x] add query group stats constructs" #15483

Closed
wants to merge 1 commit into from

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 28, 2024

Reverts #15473

@reta
Copy link
Collaborator Author

reta commented Aug 28, 2024

The pull request (#15473) was merged while breaking API compatibility checks and as such - blocks all further pull requests from being merged.

@reta reta force-pushed the revert-15473-backport/backport-15343-to-2.x branch from 7ddcf80 to 9cd2635 Compare August 28, 2024 19:26
Copy link
Contributor

❌ Gradle check result for 7ddcf80: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 9cd2635: SUCCESS

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.08%. Comparing base (c63ad5a) to head (9cd2635).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15483      +/-   ##
============================================
+ Coverage     71.72%   72.08%   +0.36%     
- Complexity    63609    63939     +330     
============================================
  Files          5216     5214       -2     
  Lines        297554   297446     -108     
  Branches      43311    43299      -12     
============================================
+ Hits         213417   214419    +1002     
+ Misses        66330    65452     -878     
+ Partials      17807    17575     -232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaushalmahi12
Copy link
Contributor

kaushalmahi12 commented Aug 29, 2024

@reta I don't think we need to revert these changes. I had commented on this issue let me know if I am missing anything here

@jainankitk
Copy link
Collaborator

Closing this PR in favor of actual fix: #15486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants