Pluggable deciders for concurrent search #15363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for 70ef9b7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Gankris96
force-pushed
the
concurrent-search-deciders
branch
from
70ef9b7
to
c0a3396
Compare
|
❌ Gradle check result for c0a3396: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Gankris96
force-pushed
the
concurrent-search-deciders
branch
from
c0a3396
to
1a7a15a
Compare
|
❌ Gradle check result for 1a7a15a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Gankris96
force-pushed
the
concurrent-search-deciders
branch
from
1a7a15a
to
708a158
Compare
|
❌ Gradle check result for 708a158: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Gankris96
force-pushed
the
concurrent-search-deciders
branch
from
708a158
to
2f7a791
Compare
|
❌ Gradle check result for 2f7a791: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Gankris96
force-pushed
the
concurrent-search-deciders
branch
from
2f7a791
to
ddf6098
Compare
Gankris96
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli and
shwetathareja
as code owners
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/16/
|
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/743/
|
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/17/
|
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15363-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 442a92845391befb9ec7b58025d01683924c0282
# Push it to GitHub
git push --set-upstream origin backport/backport-15363-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
Gankris96
added a commit
to Gankris96/OpenSearch
that referenced
this pull request
Sep 3, 2024
Signed-off-by: Ganesh Ramadurai <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Jay Deng <[email protected]> (cherry picked from commit 442a928)
3 tasks
Gankris96
added a commit
to Gankris96/OpenSearch
that referenced
this pull request
Sep 3, 2024
Signed-off-by: Ganesh Ramadurai <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Jay Deng <[email protected]> (cherry picked from commit 442a928)
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15363-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 442a92845391befb9ec7b58025d01683924c0282
# Push it to GitHub
git push --set-upstream origin backport/backport-15363-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17Then, create a pull request where the |
jed326
pushed a commit
that referenced
this pull request
Sep 4, 2024
jed326
pushed a commit
that referenced
this pull request
Sep 4, 2024
This was referenced Sep 5, 2024
This was referenced Sep 6, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Ganesh Ramadurai <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Jay Deng <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Ganesh Ramadurai <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Jay Deng <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Ganesh Ramadurai <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Jay Deng <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Ganesh Ramadurai <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Jay Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces pluggable deciders for concurrent segment search decision making.
Related Issues
Resolves #15259
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.