Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star Tree Meta and Data Writers #15295

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Aug 19, 2024

Description

This PR entails the meta and data writers that will be used to actually store Star Tree in a segment.

Related Issues

Resolves #15296

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for 613f583: SUCCESS

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 87.29097% with 38 lines in your changes missing coverage. Please review.

Project coverage is 71.79%. Comparing base (acee2ae) to head (c258c1f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...be/startree/fileformats/meta/StarTreeMetadata.java 76.00% 18 Missing ⚠️
...h/index/compositeindex/datacube/ReadDimension.java 42.85% 6 Missing and 2 partials ⚠️
.../datacube/startree/StarTreeFieldConfiguration.java 66.66% 1 Missing and 2 partials ⚠️
...arch/index/compositeindex/datacube/MetricStat.java 86.66% 1 Missing and 1 partial ⚠️
.../startree/fileformats/data/StarTreeDataWriter.java 93.75% 1 Missing and 1 partial ⚠️
...tree/fileformats/node/FixedLengthStarTreeNode.java 96.66% 2 Missing ⚠️
.../index/compositeindex/CompositeIndexConstants.java 0.00% 1 Missing ⚠️
.../startree/fileformats/meta/StarTreeMetaWriter.java 97.14% 1 Missing ⚠️
...eindex/datacube/startree/node/StarTreeFactory.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15295      +/-   ##
============================================
- Coverage     71.87%   71.79%   -0.08%     
- Complexity    63318    63348      +30     
============================================
  Files          5231     5244      +13     
  Lines        296521   296789     +268     
  Branches      42832    42849      +17     
============================================
- Hits         213113   213090      -23     
- Misses        65948    66189     +241     
- Partials      17460    17510      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Copy link
Contributor

✅ Gradle check result for c258c1f: SUCCESS

@sachinpkale sachinpkale merged commit 8629279 into opensearch-project:main Aug 29, 2024
34 checks passed
@bharath-techie bharath-techie added the backport 2.x Backport to 2.x branch label Aug 29, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2024
---------
Signed-off-by: Sarthak Aggarwal <[email protected]>
(cherry picked from commit 8629279)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mgodwan mgodwan mentioned this pull request Aug 29, 2024
3 tasks
gbbafna pushed a commit that referenced this pull request Aug 30, 2024
---------
Signed-off-by: Sarthak Aggarwal <[email protected]>
(cherry picked from commit 8629279)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Indexing:Performance skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Star Tree Meta and Data Writers
4 participants