Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle runtime JDK version post 8.10 version upgrade #15270

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 15, 2024

Description

Fix Gradle runtime JDK version post 8.10 version upgrade

Related Issues

Related to #15177

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sandeshkr419
Copy link
Contributor

@reta Does this change means that we would need Java-21 or later to build OpenSearch?

@reta reta force-pushed the fix.gradle.8.10.main branch 2 times, most recently from 8425bcf to 9d37736 Compare August 15, 2024 19:32
@reta
Copy link
Collaborator Author

reta commented Aug 15, 2024

@reta Does this change means that we would need Java-21 or later to build OpenSearch?

Thanks @sandeshkr419 , eventually yes, but I reverted this part at the moment, we only need Gradle runtime to be at least JDK-17

Copy link
Contributor

❌ Gradle check result for 52fa033: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ca1ba98: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for ca1ba98: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationMultiSearchDuringFetchPhase

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.79%. Comparing base (01acf1c) to head (ca1ba98).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15270      +/-   ##
============================================
- Coverage     71.89%   71.79%   -0.10%     
+ Complexity    63111    63016      -95     
============================================
  Files          5204     5207       +3     
  Lines        295418   295581     +163     
  Branches      42680    42690      +10     
============================================
- Hits         212379   212201     -178     
- Misses        65632    65940     +308     
- Partials      17407    17440      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jed326 jed326 merged commit b316279 into opensearch-project:main Aug 15, 2024
34 of 35 checks passed
@jed326 jed326 mentioned this pull request Aug 15, 2024
8 tasks
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants