Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Refactor remote routing table service to implement remote objects #14862

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Arpit-Bandejiya
Copy link
Contributor

@Arpit-Bandejiya Arpit-Bandejiya commented Jul 22, 2024

[Backport 2.x] Refactor remote routing table service to implement remote objects (#14668)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 3fed8d4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 314c182: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8e75472: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8e75472: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dbwiddis
Copy link
Member

@Arpit-Bandejiya does this need to be backported to 2.16? If so please add that label.

Copy link
Contributor

✅ Gradle check result for 880d71e: SUCCESS

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (feaa115) to head (880d71e).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 73.33% 2 Missing and 2 partials ⚠️
...y/remote/routingtable/RemoteIndexRoutingTable.java 88.88% 1 Missing and 2 partials ⚠️
...eway/remote/model/RemoteRoutingTableBlobStore.java 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14862      +/-   ##
============================================
+ Coverage     71.45%   71.58%   +0.12%     
- Complexity    62465    62492      +27     
============================================
  Files          5107     5107              
  Lines        293633   293561      -72     
  Branches      42779    42775       -4     
============================================
+ Hits         209821   210132     +311     
+ Misses        66198    65792     -406     
- Partials      17614    17637      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 61ca56e into opensearch-project:2.x Jul 22, 2024
35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 22, 2024
…te state interfaces (#14668) (#14862)

Signed-off-by: Arpit Bandejiya <[email protected]>
(cherry picked from commit 61ca56e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dblock dblock added the v2.16.0 Issues and PRs related to version 2.16.0 label Jul 23, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.16 v2.16.0 Issues and PRs related to version 2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants