-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Get QueryGroup API Logic #14709
Add Get QueryGroup API Logic #14709
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14709 +/- ##
============================================
+ Coverage 71.80% 71.96% +0.16%
- Complexity 63090 63179 +89
============================================
Files 5207 5212 +5
Lines 295581 295649 +68
Branches 42690 42692 +2
============================================
+ Hits 212248 212776 +528
+ Misses 65901 65408 -493
- Partials 17432 17465 +33 ☔ View full report in Codecov by Sentry. |
❕ Gradle check result for 70eb0dc: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for 9379a6e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
.../workload-management/src/main/java/org/opensearch/plugin/wlm/action/GetQueryGroupAction.java
Outdated
Show resolved
Hide resolved
...-management/src/main/java/org/opensearch/plugin/wlm/action/rest/RestGetQueryGroupAction.java
Outdated
Show resolved
Hide resolved
...ent/src/main/java/org/opensearch/plugin/wlm/action/service/QueryGroupPersistenceService.java
Outdated
Show resolved
Hide resolved
...ad-management/src/test/java/org/opensearch/plugin/wlm/action/GetQueryGroupResponseTests.java
Show resolved
Hide resolved
Signed-off-by: Ruirui Zhang <[email protected]>
❌ Gradle check result for d4615c7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14709-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a900a16ce8c076488324993ec963f6a6f0e9e269
# Push it to GitHub
git push --set-upstream origin backport/backport-14709-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@ruai0511 please open a manual backport. Thanks! |
Makes sense, merged that one let me retrigger here |
* Add Get QueryGroup API Logic Signed-off-by: Ruirui Zhang <[email protected]> * add to changelog Signed-off-by: Ruirui Zhang <[email protected]> * fix javadoc Signed-off-by: Ruirui Zhang <[email protected]> * change GetQueryGroupAction NAME and add more tests Signed-off-by: Ruirui Zhang <[email protected]> * add more unit tests Signed-off-by: Ruirui Zhang <[email protected]> * fix spotlessapply Signed-off-by: Ruirui Zhang <[email protected]> * addressed comments Signed-off-by: Ruirui Zhang <[email protected]> * incorperate comments from create api PR Signed-off-by: Ruirui Zhang <[email protected]> * use clustermanager to get the most recent querygroups Signed-off-by: Ruirui Zhang <[email protected]> * address comments Signed-off-by: Ruirui Zhang <[email protected]> * rebase with main Signed-off-by: Ruirui Zhang <[email protected]> * add IT Signed-off-by: Ruirui Zhang <[email protected]> * address comments Signed-off-by: Ruirui Zhang <[email protected]> * fix IT Signed-off-by: Ruirui Zhang <[email protected]> (cherry picked from commit a900a16) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Nice, the trigger-bot succeeded after the create backport merge! |
* Add Get QueryGroup API Logic Signed-off-by: Ruirui Zhang <[email protected]> * add to changelog Signed-off-by: Ruirui Zhang <[email protected]> * fix javadoc Signed-off-by: Ruirui Zhang <[email protected]> * change GetQueryGroupAction NAME and add more tests Signed-off-by: Ruirui Zhang <[email protected]> * add more unit tests Signed-off-by: Ruirui Zhang <[email protected]> * fix spotlessapply Signed-off-by: Ruirui Zhang <[email protected]> * addressed comments Signed-off-by: Ruirui Zhang <[email protected]> * incorperate comments from create api PR Signed-off-by: Ruirui Zhang <[email protected]> * use clustermanager to get the most recent querygroups Signed-off-by: Ruirui Zhang <[email protected]> * address comments Signed-off-by: Ruirui Zhang <[email protected]> * rebase with main Signed-off-by: Ruirui Zhang <[email protected]> * add IT Signed-off-by: Ruirui Zhang <[email protected]> * address comments Signed-off-by: Ruirui Zhang <[email protected]> * fix IT Signed-off-by: Ruirui Zhang <[email protected]> (cherry picked from commit a900a16) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add Get QueryGroup API Logic Signed-off-by: Ruirui Zhang <[email protected]> * add to changelog Signed-off-by: Ruirui Zhang <[email protected]> * fix javadoc Signed-off-by: Ruirui Zhang <[email protected]> * change GetQueryGroupAction NAME and add more tests Signed-off-by: Ruirui Zhang <[email protected]> * add more unit tests Signed-off-by: Ruirui Zhang <[email protected]> * fix spotlessapply Signed-off-by: Ruirui Zhang <[email protected]> * addressed comments Signed-off-by: Ruirui Zhang <[email protected]> * incorperate comments from create api PR Signed-off-by: Ruirui Zhang <[email protected]> * use clustermanager to get the most recent querygroups Signed-off-by: Ruirui Zhang <[email protected]> * address comments Signed-off-by: Ruirui Zhang <[email protected]> * rebase with main Signed-off-by: Ruirui Zhang <[email protected]> * add IT Signed-off-by: Ruirui Zhang <[email protected]> * address comments Signed-off-by: Ruirui Zhang <[email protected]> * fix IT Signed-off-by: Ruirui Zhang <[email protected]>
* Add Get QueryGroup API Logic Signed-off-by: Ruirui Zhang <[email protected]> * add to changelog Signed-off-by: Ruirui Zhang <[email protected]> * fix javadoc Signed-off-by: Ruirui Zhang <[email protected]> * change GetQueryGroupAction NAME and add more tests Signed-off-by: Ruirui Zhang <[email protected]> * add more unit tests Signed-off-by: Ruirui Zhang <[email protected]> * fix spotlessapply Signed-off-by: Ruirui Zhang <[email protected]> * addressed comments Signed-off-by: Ruirui Zhang <[email protected]> * incorperate comments from create api PR Signed-off-by: Ruirui Zhang <[email protected]> * use clustermanager to get the most recent querygroups Signed-off-by: Ruirui Zhang <[email protected]> * address comments Signed-off-by: Ruirui Zhang <[email protected]> * rebase with main Signed-off-by: Ruirui Zhang <[email protected]> * add IT Signed-off-by: Ruirui Zhang <[email protected]> * address comments Signed-off-by: Ruirui Zhang <[email protected]> * fix IT Signed-off-by: Ruirui Zhang <[email protected]>
Description
This change introduces the Get QueryGroup API which we will use to enforce node level resiliency as part of this RFC: #12342. The draft PR opened for the API specs is: opensearch-project/opensearch-api-specification#356
The Get QueryGroup API schema is:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.