-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump HdrHistogram to 2.2.2 and move the dependency version to version.properties #13986
Conversation
❌ Gradle check result for af271f6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
af271f6
to
fba12bd
Compare
Signed-off-by: LantaoJin <[email protected]>
Signed-off-by: LantaoJin <[email protected]>
fba12bd
to
c83e229
Compare
❕ Gradle check result for fba12bd: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13986 +/- ##
============================================
+ Coverage 71.42% 71.62% +0.20%
- Complexity 59978 61378 +1400
============================================
Files 4985 5071 +86
Lines 282275 288390 +6115
Branches 40946 41764 +818
============================================
+ Hits 201603 206572 +4969
- Misses 63999 64728 +729
- Partials 16673 17090 +417 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for c83e229: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13986-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 298aeda5fdffaa4f6a707d7b0248f7871cf83d80
# Push it to GitHub
git push --set-upstream origin backport/backport-13986-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@LantaoJin could you please backport to |
@reta sure, I will backport this to 2.x. |
….properties (#13986) (#14040) Signed-off-by: LantaoJin <[email protected]> (cherry picked from commit 298aeda)
….properties (opensearch-project#13986) Signed-off-by: LantaoJin <[email protected]>
….properties (opensearch-project#13986) (opensearch-project#14040) Signed-off-by: LantaoJin <[email protected]> (cherry picked from commit 298aeda) Signed-off-by: kkewwei <[email protected]>
….properties (opensearch-project#13986) Signed-off-by: LantaoJin <[email protected]>
Description
Sourced from org.hdrhistogram:HdrHistogram's releases.
t-digest
andhdrhistogram
to version.properties and fix a typo in comment.Upgraded to t-digest 3.3. #3634 upgraded t-digest to 3.3 in main only, but keep using 3.2 in 2.x branch. SQL plugin which depends on these percentile aggregation dependencies has to set different versions for each branch. Move the versions to
version.properties
file could reduce the dependency maintenance efforts in plugins.Related Issues
Followup #3634
Duplicates #13937
Check List
[ ] New functionality includes testing.[ ] All tests pass[ ] New functionality has been documented.[ ] New functionality has javadoc added[ ] API changes companion pull request created.[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.