-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass parent filter to inner hit query #13903
Conversation
Signed-off-by: Heemin Kim <[email protected]>
❌ Gradle check result for 5cf0070: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
For the record, the difference versus the previous PR is:
in the test. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13903 +/- ##
============================================
+ Coverage 71.42% 71.63% +0.21%
- Complexity 59978 61341 +1363
============================================
Files 4985 5064 +79
Lines 282275 288093 +5818
Branches 40946 41716 +770
============================================
+ Hits 201603 206370 +4767
- Misses 63999 64722 +723
- Partials 16673 17001 +328 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13903-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6c9603a795cc98945af2d0d9771091ecdb09e61f
# Push it to GitHub
git push --set-upstream origin backport/backport-13903-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 6c9603a)
Backport PR: #13906 |
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 6c9603a)
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 6c9603a)
Signed-off-by: Heemin Kim <[email protected]>
…nsearch-project#13906) Signed-off-by: kkewwei <[email protected]>
Signed-off-by: Heemin Kim <[email protected]>
Description
Parent filter is passed to nested query in #10246 PR. The same parent filter should be passed to inner query so that innerHit can utilize the data for correct innerHit result. Without this PR, the result in innerHit does not align with original query result.
Related Issues
opensearch-project/k-NN#1447
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.