Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] FEATURE-13448: add use compound file setting (#13478) #13608

Merged

Conversation

andrross
Copy link
Member

@andrross andrross commented May 8, 2024

Backports 14cd0e3 from #13478 to 2.x

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* add use compound file setting

Signed-off-by: Samuel Herman <[email protected]>

* review feedback

Signed-off-by: Samuel Herman <[email protected]>

---------

Signed-off-by: Samuel Herman <[email protected]>
(cherry picked from commit 14cd0e3)
@reta
Copy link
Collaborator

reta commented May 8, 2024

Thanks @andrross !

Copy link
Contributor

github-actions bot commented May 8, 2024

✅ Gradle check result for 1d879fd: SUCCESS

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.26%. Comparing base (0dd892c) to head (1d879fd).
Report is 238 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13608      +/-   ##
============================================
- Coverage     71.28%   71.26%   -0.02%     
- Complexity    60145    61174    +1029     
============================================
  Files          4957     5028      +71     
  Lines        282799   287800    +5001     
  Branches      41409    42069     +660     
============================================
+ Hits         201591   205101    +3510     
- Misses        64189    65373    +1184     
- Partials      17019    17326     +307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit df0b65b into opensearch-project:2.x May 8, 2024
48 checks passed
@andrross andrross deleted the backport/backport-13478-to-2.x branch May 10, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants