-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flaky test] Clear transient cluster setting at the end of the test #13508
Conversation
❌ Gradle check result for b580023: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 0a40e2e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b580023: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 0a40e2e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b580023: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@gbbafna looks like Spotless is complaining. Can you please format and push again? |
❌ Gradle check result for 2f8ff13: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2f8ff13: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Remove check of non zero assertion of time as it is non deterministic Signed-off-by: Gaurav Bafna <[email protected]>
❌ Gradle check result for 24d986c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 24d986c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13508 +/- ##
============================================
+ Coverage 71.42% 71.55% +0.13%
- Complexity 59978 61086 +1108
============================================
Files 4985 5051 +66
Lines 282275 287119 +4844
Branches 40946 41602 +656
============================================
+ Hits 201603 205452 +3849
- Misses 63999 64675 +676
- Partials 16673 16992 +319 ☔ View full report in Codecov by Sentry. |
Remove check of non zero assertion of time as it is non deterministic Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit 89c6c27) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Remove check of non zero assertion of time as it is non deterministic Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit 89c6c27) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oject#13508) Remove check of non zero assertion of time as it is non deterministic Signed-off-by: Gaurav Bafna <[email protected]>
…oject#13508) Remove check of non zero assertion of time as it is non deterministic Signed-off-by: Gaurav Bafna <[email protected]>
…oject#13508) Remove check of non zero assertion of time as it is non deterministic Signed-off-by: Gaurav Bafna <[email protected]>
Description
Clear transient cluster setting at the end of the test to ensure test clean up doesn't fail
Remove check of non zero assertion of time as it is non deterministic
Related Issues
Resolves #11179 , #11221
Check List
New functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.