Update supported version for the primary_only parameter in force-merge API #12657

gaobinlong · 2024-03-14T06:38:45Z

Description

After the PR was backported to the 2.x branch, we need to update the supported version for that enhancement to make sure the unit test and yml test can cover the change.

Backport to 2.x is not needed.

Related Issues

#8021

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…erge API Signed-off-by: Gao Binlong <[email protected]>

Signed-off-by: Gao Binlong <[email protected]>

github-actions · 2024-03-14T07:01:19Z

Compatibility status:

Checks if related components are compatible with change 8ffca13

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

github-actions · 2024-03-14T07:20:11Z

❌ Gradle check result for bc44f08: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-03-14T07:27:36Z

❕ Gradle check result for 380451f: UNSTABLE

TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testContainerCreationAndDeletion

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-03-14T07:28:34Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.50%. Comparing base (b15cb0c) to head (8ffca13).
Report is 43 commits behind head on main.

Files	Patch %	Lines
...on/admin/indices/forcemerge/ForceMergeRequest.java	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12657      +/-   ##
============================================
+ Coverage     71.42%   71.50%   +0.08%     
- Complexity    59978    60137     +159     
============================================
  Files          4985     4992       +7     
  Lines        282275   282838     +563     
  Branches      40946    41025      +79     
============================================
+ Hits         201603   202246     +643     
+ Misses        63999    63807     -192     
- Partials      16673    16785     +112

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gaobinlong · 2024-03-14T07:34:36Z

❕ Gradle check result for 380451f: UNSTABLE

TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testContainerCreationAndDeletion
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Known issue: #10940

server/src/test/java/org/opensearch/action/admin/indices/forcemerge/ForceMergeRequestTests.java

CHANGELOG.md

Signed-off-by: Gao Binlong <[email protected]>

github-actions · 2024-03-15T06:50:05Z

❕ Gradle check result for f8539ee: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.RemoteStoreIT.testResumeUploadAfterFailedPrimaryRelocation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2024-03-15T06:54:01Z

✅ Gradle check result for f7375f6: SUCCESS

server/src/test/java/org/opensearch/action/admin/indices/forcemerge/ForceMergeRequestTests.java

Signed-off-by: Gao Binlong <[email protected]>

github-actions · 2024-03-18T03:34:56Z

❌ Gradle check result for 7c06d62:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-03-18T07:26:29Z

✅ Gradle check result for 8ffca13: SUCCESS

sohami

lgtm. @reta Let me know if you are fine with this change as well

@gaobinlong Do we need corresponding test update in 2.x branch ?

sohami · 2024-03-20T03:06:43Z

@gaobinlong Can you look into the tests in 2.x branch and fix those as well ?

gaobinlong · 2024-03-20T03:08:42Z

@gaobinlong Can you look into the tests in 2.x branch and fix those as well ?

Sure, I'll do that.

…e API (opensearch-project#12657) * Update supported version for adding primary_only parameter to force-merge API Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> * Remove some unused code Signed-off-by: Gao Binlong <[email protected]> * Remove change log Signed-off-by: Gao Binlong <[email protected]> * Fix test issue Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>

Update supported version for adding primary_only parameter to force-m…

380451f

…erge API Signed-off-by: Gao Binlong <[email protected]>

Modify change log

bc44f08

Signed-off-by: Gao Binlong <[email protected]>

reta reviewed Mar 14, 2024

View reviewed changes

server/src/test/java/org/opensearch/action/admin/indices/forcemerge/ForceMergeRequestTests.java Outdated Show resolved Hide resolved

kotwanikunal reviewed Mar 14, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

gaobinlong added 3 commits March 15, 2024 13:58

Remove some unused code

f8539ee

Signed-off-by: Gao Binlong <[email protected]>

Remove change log

4c45a9e

Signed-off-by: Gao Binlong <[email protected]>

Merge remote-tracking branch 'upstream/main' into primary_only

f7375f6

sohami added the skip-changelog label Mar 15, 2024

sohami reviewed Mar 15, 2024

View reviewed changes

server/src/test/java/org/opensearch/action/admin/indices/forcemerge/ForceMergeRequestTests.java Outdated Show resolved Hide resolved

gaobinlong added 2 commits March 18, 2024 11:31

Fix test issue

b3048fe

Signed-off-by: Gao Binlong <[email protected]>

Merge remote-tracking branch 'upstream/main' into primary_only

7c06d62

Merge remote-tracking branch 'upstream/main' into primary_only

8ffca13

sohami approved these changes Mar 19, 2024

View reviewed changes

sohami merged commit 1b4c76d into opensearch-project:main Mar 20, 2024
30 of 31 checks passed

gaobinlong mentioned this pull request Mar 20, 2024

Fix test bwcSerialization issue in ForceMergeRequestTests #12778

Merged

8 tasks

gaobinlong mentioned this pull request Apr 18, 2024

Update supported version in yaml test file for the primary_only parameter in force-merge API #13279

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update supported version for the primary_only parameter in force-merge API #12657

Update supported version for the primary_only parameter in force-merge API #12657

gaobinlong commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

codecov bot commented Mar 14, 2024 •

edited

Loading

gaobinlong commented Mar 14, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

sohami left a comment •

edited

Loading

sohami commented Mar 20, 2024

gaobinlong commented Mar 20, 2024

Update supported version for the primary_only parameter in force-merge API #12657

Update supported version for the primary_only parameter in force-merge API #12657

Conversation

gaobinlong commented Mar 14, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Mar 14, 2024 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

codecov bot commented Mar 14, 2024 • edited Loading

Codecov Report

gaobinlong commented Mar 14, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

sohami left a comment • edited Loading

Choose a reason for hiding this comment

sohami commented Mar 20, 2024

gaobinlong commented Mar 20, 2024

gaobinlong commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024 •

edited

Loading

codecov bot commented Mar 14, 2024 •

edited

Loading

sohami left a comment •

edited

Loading