Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with CPU admission controller for cluster-manager Read API's. #12496

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

rajiv-kv
Copy link
Contributor

@rajiv-kv rajiv-kv commented Feb 29, 2024

Description

Read actions of ClusterManager are integrated with admission control at transport layer. These transport actions are used by Admin API's to retrive information such as stats and metadata from cluster-state.
Sub-classes of TransportClusterManagerNodeReadAction that already have Circuit breaker limit enforced today have been additionally enforced with admission control. Action Type CLUSTER_INFO is introduced to configure admission thresholds & options for the Admin API's.

Related Issues

Resolves #7520

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added discuss Issues intended to help drive brainstorming and decision making distributed framework enhancement Enhancement or improvement to existing feature or request idea Things we're kicking around. RFC Issues requesting major changes labels Feb 29, 2024
Copy link
Contributor

github-actions bot commented Feb 29, 2024

Compatibility status:

Checks if related components are compatible with change d9e42b5

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 68968cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@shwetathareja shwetathareja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajiv-kv. On high level this looks good. Left few comments/ clarifications.

Copy link
Contributor

❌ Gradle check result for 8f3a5ea: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 40fb58c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja
Copy link
Member

@rajiv-kv : Below test failed again.

[org.opensearch.ratelimitting.admissioncontrol.AdmissionForClusterManagerIT.testAdmissionControlEnforced](https://build.ci.opensearch.org/job/gradle-check/35460/testReport/junit/org.opensearch.ratelimitting.admissioncontrol/AdmissionForClusterManagerIT/testAdmissionControlEnforced/)
    [org.opensearch.ratelimitting.admissioncontrol.AdmissionForClusterManagerIT.testAdmissionControlMonitorOnBreach](https://build.ci.opensearch.org/job/gradle-check/35460/testReport/junit/org.opensearch.ratelimitting.admissioncontrol/AdmissionForClusterManagerIT/testAdmissionControlMonitorOnBreach/)
    [org.opensearch.ratelimitting.admissioncontrol.AdmissionForClusterManagerIT.testAdmissionControlResponseStatus](https://build.ci.opensearch.org/job/gradle-check/35460/testReport/junit/org.opensearch.ratelimitting.admissioncontrol/AdmissionForClusterManagerIT/testAdmissionControlResponseStatus/)
    [org.opensearch.ratelimitting.admissioncontrol.AdmissionForClusterManagerIT.testAdmissionControlDisabledOnBreach](https://build.ci.opensearch.org/job/gradle-check/35460/testReport/junit/org.opensearch.ratelimitting.admissioncontrol/AdmissionForClusterManagerIT/testAdmissionControlDisabledOnBreach/)

Copy link
Contributor

✅ Gradle check result for b6f885a: SUCCESS

Copy link
Contributor

❌ Gradle check result for f55fe37: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

The admission control is enforced at the transport layer.

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Copy link
Contributor

✅ Gradle check result for d9e42b5: SUCCESS

@shwetathareja shwetathareja self-requested a review March 21, 2024 09:12
@shwetathareja shwetathareja merged commit 2069bd8 into opensearch-project:main Mar 21, 2024
33 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Mar 21, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12496-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2069bd805804dd93bd69695a4c6521cc6f2b9bb6
# Push it to GitHub
git push --set-upstream origin backport/backport-12496-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12496-to-2.x.

rajiv-kv added a commit to rajiv-kv/OpenSearch that referenced this pull request Mar 21, 2024
…s. (opensearch-project#12496)

* Integrate with CPU admission controller for cluster-manager Read API's.
The admission control is enforced at the transport layer.

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
rajiv-kv added a commit to rajiv-kv/OpenSearch that referenced this pull request Mar 21, 2024
…s. (opensearch-project#12496)

* Integrate with CPU admission controller for cluster-manager Read API's.
The admission control is enforced at the transport layer.

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
shwetathareja pushed a commit that referenced this pull request Mar 21, 2024
…s. (#12496) (#12829)

* Integrate with CPU admission controller for cluster-manager Read API's.
The admission control is enforced at the transport layer.

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
shwetathareja pushed a commit that referenced this pull request Mar 21, 2024
…s. (#12496) (#12832)

* Integrate with CPU admission controller for cluster-manager Read API's.
The admission control is enforced at the transport layer.

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…s. (opensearch-project#12496)

* Integrate with CPU admission controller for cluster-manager Read API's.
The admission control is enforced at the transport layer.

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed Cluster Manager discuss Issues intended to help drive brainstorming and decision making distributed framework enhancement Enhancement or improvement to existing feature or request idea Things we're kicking around. RFC Issues requesting major changes v2.13.0 Issues and PRs related to version 2.13.0
Projects
Status: ✅ Done
Status: No status
Development

Successfully merging this pull request may close these issues.

[RFC] Admission Control mechanism for Cluster Manager APIs
4 participants