Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Automatic addition of protocol broken in #11512 #11609

Closed
dblock opened this issue Dec 13, 2023 · 1 comment · Fixed by #11612
Closed

[BUG] Automatic addition of protocol broken in #11512 #11609

dblock opened this issue Dec 13, 2023 · 1 comment · Fixed by #11612
Labels
bug Something isn't working Other

Comments

@dblock
Copy link
Member

dblock commented Dec 13, 2023

Describe the bug

Coming from #11512, the check examines the host for http which is broken for httpserver.example.com. See #11512 (comment).

Expected behavior

Check for full protocol, http:// and https://.

@dblock dblock added bug Something isn't working untriaged labels Dec 13, 2023
@dblock
Copy link
Member Author

dblock commented Dec 13, 2023

@heyanlong

heyanlong added a commit to heyanlong/OpenSearch that referenced this issue Dec 14, 2023
Signed-off-by: Yanlong He <[email protected]>
heyanlong added a commit to heyanlong/OpenSearch that referenced this issue Dec 15, 2023
dblock pushed a commit that referenced this issue Dec 18, 2023
* Fix #11609

Signed-off-by: Yanlong He <[email protected]>

* Fix #11609

Signed-off-by: heyanlong <[email protected]>

* Update AwsEc2ServiceImplTests.java

Signed-off-by: 何延龙 <[email protected]>

* spotless

Signed-off-by: heyanlong <[email protected]>

---------

Signed-off-by: Yanlong He <[email protected]>
Signed-off-by: heyanlong <[email protected]>
Signed-off-by: 何延龙 <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Dec 18, 2023
* Fix #11609

Signed-off-by: Yanlong He <[email protected]>

* Fix #11609

Signed-off-by: heyanlong <[email protected]>

* Update AwsEc2ServiceImplTests.java

Signed-off-by: 何延龙 <[email protected]>

* spotless

Signed-off-by: heyanlong <[email protected]>

---------

Signed-off-by: Yanlong He <[email protected]>
Signed-off-by: heyanlong <[email protected]>
Signed-off-by: 何延龙 <[email protected]>
(cherry picked from commit 2b1c9ae)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this issue Mar 18, 2024
…project#11612)

* Fix opensearch-project#11609

Signed-off-by: Yanlong He <[email protected]>

* Fix opensearch-project#11609

Signed-off-by: heyanlong <[email protected]>

* Update AwsEc2ServiceImplTests.java

Signed-off-by: 何延龙 <[email protected]>

* spotless

Signed-off-by: heyanlong <[email protected]>

---------

Signed-off-by: Yanlong He <[email protected]>
Signed-off-by: heyanlong <[email protected]>
Signed-off-by: 何延龙 <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this issue Apr 25, 2024
…project#11612)

* Fix opensearch-project#11609

Signed-off-by: Yanlong He <[email protected]>

* Fix opensearch-project#11609

Signed-off-by: heyanlong <[email protected]>

* Update AwsEc2ServiceImplTests.java

Signed-off-by: 何延龙 <[email protected]>

* spotless

Signed-off-by: heyanlong <[email protected]>

---------

Signed-off-by: Yanlong He <[email protected]>
Signed-off-by: heyanlong <[email protected]>
Signed-off-by: 何延龙 <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Other
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants