Deprecate CamelCase PathHierarchy tokenizer name #10894

lukas-vlcek · 2023-10-24T14:47:33Z

Description

Deprecate CamelCase PathHierarchy tokenizer name in favor to LowerCase path_hierarchy.

Related Issues

Note: Taking out all items from the below check list relevant to "new functionality" as there is no new functionality in this PR.

Check List

~~New functionality includes testing.~~

All tests pass
~~New functionality has been documented.~~
~~New functionality has javadoc added~~
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-10-24T15:07:37Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/28920/
CommitID: 01d920a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-24T15:17:03Z

Compatibility status:

Checks if related components are compatible with change cb58488

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

github-actions · 2023-10-24T15:17:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/28921/
CommitID: a3909c0
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-26T12:58:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29080/
CommitID: b0f6574
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

lukas-vlcek · 2023-10-26T13:19:56Z

BTW, when back-ported to 2.x changes in 30_tokenizers.yml rest test file should be dropped.

github-actions · 2023-10-26T13:39:23Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/29081/
CommitID: 3e03262

codecov · 2023-10-26T13:40:31Z

Codecov Report

Merging #10894 (cb58488) into main (be65f54) will decrease coverage by 0.03%.
Report is 27 commits behind head on main.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main   #10894      +/-   ##
============================================
- Coverage     71.21%   71.19%   -0.03%     
+ Complexity    58689    58677      -12     
============================================
  Files          4870     4870              
  Lines        276539   276545       +6     
  Branches      40190    40190              
============================================
- Hits         196945   196874      -71     
- Misses        63192    63223      +31     
- Partials      16402    16448      +46

Files	Coverage Δ
...ch/analysis/common/CommonAnalysisModulePlugin.java	`90.90% <50.00%> (-1.19%)`	⬇️

... and 479 files with indirect coverage changes

...analysis-common/src/main/java/org/opensearch/analysis/common/CommonAnalysisModulePlugin.java

lukas-vlcek · 2023-11-02T17:10:42Z

Update: While I was trying to implement a test for the deprecation I run into unexpected Lucene problem. See apache/lucene#12750
In the meantime I will need to find a different way of how to implement the test (I think there should be some alternative).

...lysis-common/src/yamlRestTest/resources/rest-api-spec/test/analysis-common/30_tokenizers.yml

...-common/src/test/java/org/opensearch/analysis/common/PathHierarchyTokenizerFactoryTests.java

github-actions · 2023-11-06T15:17:01Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteBlobWithRetries
      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

URL: https://build.ci.opensearch.org/job/gradle-check/29584/
CommitID: 7d1c06e
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2023-11-06T16:18:32Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29588/
CommitID: a97ebd5
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-06T16:27:28Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29589/
CommitID: 168b256
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-06T16:35:22Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29590/
CommitID: f6d25cd
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Deprecate CamelCase PathHierarchy tokenizer name in favor to lowercase path_hierarchy. Signed-off-by: Lukáš Vlček <[email protected]>

github-actions · 2023-11-06T18:23:54Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      3 org.opensearch.index.shard.RemoteIndexShardTests.classMethod
      1 org.opensearch.index.shard.RemoteIndexShardTests.testSegmentReplication_With_EngineClosedConcurrently

URL: https://build.ci.opensearch.org/job/gradle-check/29596/
CommitID: cb58488
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

…10894) Deprecate CamelCase PathHierarchy tokenizer name in favor to lowercase path_hierarchy. Signed-off-by: Lukáš Vlček <[email protected]>

…10894) Deprecate CamelCase PathHierarchy tokenizer name in favor to lowercase path_hierarchy. Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>

lukas-vlcek force-pushed the PathHierarchy branch from 01d920a to a3909c0 Compare October 24, 2023 14:49

lukas-vlcek force-pushed the PathHierarchy branch from a3909c0 to b0f6574 Compare October 26, 2023 12:53

reta reviewed Oct 26, 2023

View reviewed changes

...analysis-common/src/main/java/org/opensearch/analysis/common/CommonAnalysisModulePlugin.java Show resolved Hide resolved

lukas-vlcek force-pushed the PathHierarchy branch from 3e03262 to 7d1c06e Compare November 6, 2023 14:24

lukas-vlcek requested a review from adnapibar as a code owner November 6, 2023 14:24

reta reviewed Nov 6, 2023

View reviewed changes

...lysis-common/src/yamlRestTest/resources/rest-api-spec/test/analysis-common/30_tokenizers.yml Show resolved Hide resolved

reta reviewed Nov 6, 2023

View reviewed changes

...-common/src/test/java/org/opensearch/analysis/common/PathHierarchyTokenizerFactoryTests.java Outdated Show resolved Hide resolved

lukas-vlcek force-pushed the PathHierarchy branch 3 times, most recently from 168b256 to f6d25cd Compare November 6, 2023 16:13

Deprecate CamelCase PathHierarchy tokenizer name

cb58488

Deprecate CamelCase PathHierarchy tokenizer name in favor to lowercase path_hierarchy. Signed-off-by: Lukáš Vlček <[email protected]>

lukas-vlcek force-pushed the PathHierarchy branch from f6d25cd to cb58488 Compare November 6, 2023 17:27

reta approved these changes Nov 6, 2023

View reviewed changes

reta added v3.0.0 Issues and PRs related to version 3.0.0 Indexing & Search labels Nov 6, 2023

kkmr approved these changes Nov 8, 2023

View reviewed changes

reta merged commit a782f4f into opensearch-project:main Nov 8, 2023
34 of 35 checks passed

reta mentioned this pull request Nov 8, 2023

List of deprecated code removal in 3.0 #2773

Open

19 tasks

lukas-vlcek deleted the PathHierarchy branch November 8, 2023 15:02

reta mentioned this pull request Nov 15, 2023

[META] Breaking changes in 3.0 #3351

Open

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate CamelCase PathHierarchy tokenizer name #10894

Deprecate CamelCase PathHierarchy tokenizer name #10894

lukas-vlcek commented Oct 24, 2023 •

edited

Loading

github-actions bot commented Oct 24, 2023

github-actions bot commented Oct 24, 2023 •

edited

Loading

github-actions bot commented Oct 24, 2023

github-actions bot commented Oct 26, 2023

lukas-vlcek commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

codecov bot commented Oct 26, 2023 •

edited

Loading

lukas-vlcek commented Nov 2, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

Deprecate CamelCase PathHierarchy tokenizer name #10894

Deprecate CamelCase PathHierarchy tokenizer name #10894

Conversation

lukas-vlcek commented Oct 24, 2023 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Oct 24, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 24, 2023 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Oct 24, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 26, 2023

Gradle Check (Jenkins) Run Completed with:

lukas-vlcek commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Oct 26, 2023 • edited Loading

Codecov Report

lukas-vlcek commented Nov 2, 2023

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

lukas-vlcek commented Oct 24, 2023 •

edited

Loading

github-actions bot commented Oct 24, 2023 •

edited

Loading

codecov bot commented Oct 26, 2023 •

edited

Loading