Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Segment Replication] Support realtime reads with TermVector Requests for segrep enabled indices #9563

Closed
Rishikesh1159 opened this issue Aug 25, 2023 · 0 comments · Fixed by #9585
Assignees
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep

Comments

@Rishikesh1159
Copy link
Member

Describe the bug
Currently with segment replication enabled reads with VectorTerm requests give incorrect results if the search request goes to replica shard before it has caught up with primary.

Integration tests in GetTermvectorsIT.java fail with segment replication enabled

java.lang.AssertionError: doc id: 9 doesn't exists but should
Expected: <true>
     but: was <false>
	at __randomizedtesting.SeedInfo.seed([F873E5CD32208FA6:279D1107D2CFBEED]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
	at org.junit.Assert.assertThat(Assert.java:964)
	at org.opensearch.action.termvectors.GetTermVectorsIT.testSimpleTermVectors(GetTermVectorsIT.java:243)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)

To Reproduce
-> Enable segment replication
-> Run GetTermvectorsIT.java

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.action.termvectors.GetTermVectorsIT.testRandomSingleTermVectors" -Dtests.seed=F873E5CD32208FA6 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=pt-BR -Dtests.timezone=America/Rainy_River -Druntime.java=20

Expected behavior
A clear and concise description of what you expected to happen.

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Rishikesh1159 Rishikesh1159 added bug Something isn't working untriaged Indexing:Replication Issues and PRs related to core replication framework eg segrep and removed untriaged labels Aug 25, 2023
@Rishikesh1159 Rishikesh1159 changed the title [BUG][Segment Replication] Support realtime reads with VectorTerm Requests for segrep enabled indices [BUG][Segment Replication] Support realtime reads with TermVector Requests for segrep enabled indices Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep
Projects
None yet
1 participant