Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Tracing Framework] Wrongly setting the current span. #9449

Closed
Tracked by #7542
Gaganjuneja opened this issue Aug 20, 2023 · 0 comments · Fixed by #9617 · May be fixed by #9450
Closed
Tracked by #7542

[BUG][Tracing Framework] Wrongly setting the current span. #9449

Gaganjuneja opened this issue Aug 20, 2023 · 0 comments · Fixed by #9617 · May be fixed by #9450
Labels
bug Something isn't working v2.10.0

Comments

@Gaganjuneja
Copy link
Contributor

Describe the bug
Tracing framework after ending the current span internally set the parent as a current span in the thread context. But after this change #8428 now parent can be ended even before the span so the assumption that parent should always be closed after child doesnt hold true. Now setting the already ended parent as a current span doesn't make sense. Adding parent as a current span only if it is still recording.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.10.0
Projects
None yet
2 participants