Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total successful task count in nodeStats API of SearchBackpressureService. #8698

Open
kaushalmahi12 opened this issue Jul 14, 2023 · 1 comment
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc

Comments

@kaushalmahi12
Copy link
Contributor

kaushalmahi12 commented Jul 14, 2023

Is your feature request related to a problem? Please describe.
Adding total successful task in searchShardTaskStats and searchTaskStats pojos to support autotune of heap based thresholds. Since the SBP Service node stats only include cancellation stats for shard and coordinator level requests, it is impossible to calculate the cancellation percentage due to a resource.

Describe the solution you'd like
We want to include total successful task count in the searchbackpressure stats at shard and coordinator level data.

Describe alternatives you've considered
N/A.

Additional context
We are planning to make use of this field to auto tune the SBP heap based cancellation thresholds at shard and coordinator level.

Related issues

@kaushalmahi12 kaushalmahi12 added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 14, 2023
@PritLadani
Copy link
Contributor

PritLadani commented Jul 15, 2023

Shall we also include a metric suggesting whether the node is under duress or not? It will be useful for investigation.
IsNodeUnderDuress can be added in the SearchBackpressureStats pojo.

@Poojita-Raj Poojita-Raj added Search Search query, autocomplete ...etc and removed untriaged labels Jul 17, 2023
@getsaurabh02 getsaurabh02 moved this from 🆕 New to Later (6 months plus) in Search Project Board Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc
Projects
Status: Later (6 months plus)
Development

No branches or pull requests

3 participants