Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flaky test org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessOnThirdAttemptAttempt #8549

Closed
ashking94 opened this issue Jul 9, 2023 · 5 comments · Fixed by #8550
Labels
bug Something isn't working Storage:Durability Issues and PRs related to the durability framework untriaged v2.9.0 'Issues and PRs related to version v2.9.0'

Comments

@ashking94
Copy link
Member

Describe the bug
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessOnThirdAttemptAttempt Test is flaky.

To Reproduce
Build - https://build.ci.opensearch.org/job/gradle-check/19505/

Expected behavior
Test should pass.

Plugins
Standard

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@ashking94 ashking94 added bug Something isn't working Storage:Durability Issues and PRs related to the durability framework v2.9.0 'Issues and PRs related to version v2.9.0' labels Jul 9, 2023
@reta reta reopened this Jul 11, 2023
@reta
Copy link
Collaborator

reta commented Jul 11, 2023

@ashking94 @sachinpkale The issue is back :(:

[org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessOnSecondAttempt](https://build.ci.opensearch.org/job/gradle-check/19883/testReport/junit/org.opensearch.index.shard/RemoteStoreRefreshListenerTests/testRefreshSuccessOnSecondAttempt/)
[org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessOnThirdAttempt](https://build.ci.opensearch.org/job/gradle-check/19883/testReport/junit/org.opensearch.index.shard/RemoteStoreRefreshListenerTests/testRefreshSuccessOnThirdAttempt/)

[1] https://build.ci.opensearch.org/job/gradle-check/19883/
[2] https://build.ci.opensearch.org/job/gradle-check/19884

@Rishikesh1159
Copy link
Member

Rishikesh1159 commented Jul 11, 2023

@reta Seems like many of recent gradle check failures are happening with RemoteStoreRefreshListenerTests failures. I think this PR: #7119 which was recently merged is causing the gradle check to fail frequently. Will mute RemoteStoreRefreshListenerTests for now until it is fixed.

@ashking94
Copy link
Member Author

@reta The flaky tests encountered earlier has been fixed with #8550. The continuous failures coming now have come due to #7119 as mentioned by @Rishikesh1159.

@reta
Copy link
Collaborator

reta commented Jul 11, 2023

Thanks @ashking94 , the cause may change but the issue is sadly back

@ashking94
Copy link
Member Author

ashking94 commented Jul 11, 2023

I am closing this issue and tracking it in a new issue (#8631) as the issue itself is a different one caused on account of retry not being handled correctly in the above mentioned PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Storage:Durability Issues and PRs related to the durability framework untriaged v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants