Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Create dummy test plugin to exercise custom codecs and add tests #8023

Open
dreamer-89 opened this issue Jun 12, 2023 · 0 comments
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Jun 12, 2023

Is your feature request related to a problem? Please describe.
Coming as action item from bug #7781, add dummy plugin that provides custom codecs and add segment replication tests using this plugin. This is to mimic plugins such as k-NN, security-analytics which overrides CodecService. The intention is to ensure plugins which have custom codecs does not break with segment replication.

Describe the solution you'd like

  1. Add a dummy plugin that overrides CodecService.
  2. Add integration tests which verify that plugins overriding codecService works well with segment replication. Adding this plugin in tests would need some orchestration in tests, as tests today uses default codec service.

Describe alternatives you've considered

  1. Add integration tests in dependent repos (k-NN e.g.)
    • Difficult to keep tests updated with changes on core
    • Not possible to keep up with new integrations.
  2. Resort to manual test before release
    • Repeating duplicating work with every release
    • Error prone

Additional context
Add any other context or screenshots about the feature request here.

@dreamer-89 dreamer-89 added enhancement Enhancement or improvement to existing feature or request untriaged labels Jun 12, 2023
@stephen-crawford stephen-crawford added the Search Search query, autocomplete ...etc label Jun 12, 2023
@anasalkouz anasalkouz added Indexing Indexing, Bulk Indexing and anything related to indexing and removed Search Search query, autocomplete ...etc labels Jun 12, 2023
@dreamer-89 dreamer-89 changed the title [Segment Replication] Add tests for custom codecs [Segment Replication] Create dummy test plugin to exercise custom codecs and add tests Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing
Projects
None yet
Development

No branches or pull requests

3 participants