Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Segment Replication] Incorrect use of default codec and replication checkpoint #7733

Closed
dreamer-89 opened this issue May 24, 2023 · 0 comments · Fixed by #7732
Closed
Labels
bug Something isn't working distributed framework

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented May 24, 2023

Describe the bug
While working on #3881, identified couple of issues

  1. During primary shard recovery, the force segment sync call use default codec implementation vs codec defined in engine config. This is problematic when non-default Lucene codec is used and will fail codec specific validations on primary
  2. Target sends back ReplicationCheckpoint received from primary. This is problematic as primary performs validations on this received replication checkpoint from replica shard (e.g. recently we started comparing codec names for bwc).

Expected behavior

  1. During force segment sync, the replica/target should send the codec defined in engine config.
  2. Send replication checkpoint derived from replica shard.

Thanks @mch2 for figuring out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed framework
Projects
Status: Done
1 participant