Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AUTO PRs for version increments don't sign DCO #5562

Closed
dblock opened this issue Dec 13, 2022 · 3 comments
Closed

[BUG] AUTO PRs for version increments don't sign DCO #5562

dblock opened this issue Dec 13, 2022 · 3 comments
Labels

Comments

@dblock
Copy link
Member

dblock commented Dec 13, 2022

These AUTO PRs failed DCO.

#5558
#5559
#5560

Manually fixed them with:

git checkout [branch]
git commit -s --amend
git push origin [branch] -f

Expected behavior
Auto PRs to sign DCO.

@dblock dblock added bug Something isn't working untriaged good first issue Good for newcomers labels Dec 13, 2022
@rblcoder
Copy link

version.yml has signoff: true
Not sure what I am missing here.
Do we need to create an issue here https://github.com/peter-evans/create-pull-request?

@rblcoder
Copy link

@dblock version.yml has signoff: true
Shall I create an issue here https://github.com/peter-evans/create-pull-request?

@dblock
Copy link
Member Author

dblock commented Oct 17, 2023

This is very old. We have since stopped using the DCO workflow and are using the GH app to check DCO. Closing.

@dblock dblock closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants