Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the permission change for jackson-databind #5505

Closed
ryanbogan opened this issue Dec 9, 2022 · 1 comment
Closed

Evaluate the permission change for jackson-databind #5505

ryanbogan opened this issue Dec 9, 2022 · 1 comment
Labels
discuss Issues intended to help drive brainstorming and decision making untriaged

Comments

@ryanbogan
Copy link
Member

In order to jackson-databind to be used in the server folder, the SHAs, licenses, and notices had to be removed from all plugins and modules. They still have access to jackson through server, but the discovery-ec2 plugin also had the accessDeclaredMembers and suppressAccessChecks permissions in the build.gradle. For the plugin to function properly with the jackson relocation, these permissions were added to the server build.gradle. We need to evaluate whether there are any unintended consequences of adding these permissions.

Link to jackson relocation PR: #5366

@ryanbogan ryanbogan added discuss Issues intended to help drive brainstorming and decision making untriaged labels Dec 9, 2022
@dblock
Copy link
Member

dblock commented Dec 9, 2022

Looks like GH hit a snafu, dup #5504

@dblock dblock closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues intended to help drive brainstorming and decision making untriaged
Projects
None yet
Development

No branches or pull requests

2 participants