Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add upload timestamp to metada file to be used in conflict resolution #5475

Closed
sachinpkale opened this issue Dec 7, 2022 · 4 comments
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework v2.8.0 'Issues and PRs related to version v2.8.0'

Comments

@sachinpkale
Copy link
Member

Is your feature request related to a problem? Please describe.

  • Currently, we store metadata file in the remote store with: metadata__<Primary Term>__<Generation>__<UUID>.
  • Primary term and generation are used to compare 2 metadata files and to get the latest one.
  • But in some cases like primary - primary recovery, primary term and generation will be same.
  • For this, we use UUID based comparison to have random but consistent way of resolving conflicts.
  • As we are adding support for refresh level durability, it is important to get the latest uploaded metadata file.
  • We can't just add timestamp in the filename as it will result in too many metadata files.
  • The initial approach we are thinking of is to add timestamp info in the contents of metadata file.
@sachinpkale sachinpkale added enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework labels Dec 7, 2022
@sachinpkale sachinpkale added the v2.6.0 'Issues and PRs related to version v2.6.0' label Jan 16, 2023
@sachinpkale
Copy link
Member Author

Moving to 2.7.0

@sachinpkale sachinpkale added v2.7.0 and removed v2.6.0 'Issues and PRs related to version v2.6.0' labels Feb 20, 2023
@DarshitChanpura
Copy link
Member

Hey @sachinpkale This issue will be marked for next-release v2.8.0 on (Apr 17) as that is the code-freeze date for v2.7.0. Please let me know if otherwise.

@DarshitChanpura DarshitChanpura added v2.8.0 'Issues and PRs related to version v2.8.0' and removed v2.7.0 labels Apr 17, 2023
@DarshitChanpura
Copy link
Member

Tagging it for next release: v2.8.0

@sachinpkale
Copy link
Member Author

This is not required anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework v2.8.0 'Issues and PRs related to version v2.8.0'
Projects
None yet
Development

No branches or pull requests

2 participants