Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Clean up Recovery State transitions. #2588

Closed
Tracked by #2194
mch2 opened this issue Mar 24, 2022 · 1 comment
Closed
Tracked by #2194

[Segment Replication] Clean up Recovery State transitions. #2588

mch2 opened this issue Mar 24, 2022 · 1 comment
Labels
bug Something isn't working distributed framework

Comments

@mch2
Copy link
Member

mch2 commented Mar 24, 2022

The POC introduced some hacks that we need to clean up with RecoveryState. During initial shard recovery we are transitioning RecoveryStates to satisfy this state machine.

We don't need to follow these states with Segment Replication then we should refactor to bypass the state checks or gracefully transition.
@mch2 mch2 added bug Something isn't working untriaged labels Mar 24, 2022
This was referenced Mar 24, 2022
Closed
Merged
@mch2
Copy link
Member Author

mch2 commented Jul 19, 2022

Closing because we will still use peer recovery.

@mch2 mch2 closed this as completed Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working distributed framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mch2 @Rishikesh1159