Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable intervals #1859

Open
mattweber opened this issue Jan 6, 2022 · 6 comments
Open

Pluggable intervals #1859

mattweber opened this issue Jan 6, 2022 · 6 comments
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Plugins

Comments

@mattweber
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Make intervals pluggable so users can write custom intervals in search plugins.

Describe the solution you'd like
Add a plugin api that allows a user to register new intervals with named writable and named xcontents which can ultimately be used in interval queries.

Describe alternatives you've considered
Exposing more of the lucene interval functionality explicitly, see #1857 and #1858.

Additional context
A lot of functionality in open search is pluggable (queries, aggregations, suggesters, etc) and it would be great to add plugin points so users can add functionality that might never make it upstream.

@mattweber mattweber added enhancement Enhancement or improvement to existing feature or request untriaged labels Jan 6, 2022
@mattweber
Copy link
Contributor Author

FYI, I have done this for elasticsearch and can rework it for open search. I believe that if users are smart enough to write their own plugin they are smart enough to follow the expected behaviors of the api (minimal intervals, etc). Elastic did not believe that and thus the reason the PR was never accepted.

@anasalkouz
Copy link
Member

@nknize Could you look into this issue?

@saratvemulapalli
Copy link
Member

@mattweber sounds like the right way to approach it. Are you open to re-write this for opensearch?

@saratvemulapalli
Copy link
Member

@mattweber gentle ping again :)

@dbwiddis
Copy link
Member

@mattweber another gentle ping! :)

@mattweber
Copy link
Contributor Author

@saratvemulapalli @dbwiddis sorry for delay, yes I can work on this. In the process of a big move so once I get settled I will work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Plugins
Projects
None yet
Development

No branches or pull requests

5 participants