You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
JPMS doesn't solves Version Selection problem [0] and leaves it to build tools like gradle and maven to specify version for modular dependencies. The module-info.class generated does contain the version associated, but isn't used -
Since module names have to be unique, we need to decide on the common prefix. Some discussion on naming lucene modules - https://issues.apache.org/jira/browse/LUCENE-10255 which discusses naming lucene modules just with plain lucene-xxxx vsorg.apache.lucene.xxxx. My 2 cents would be to use latter convention using full qualified name - org.opensearch.xxxx, part of the reason related to how automatic modules are named in java. For a jar named ${groupID}-${artifactID}-${version}.jar, its automatic module would be named as ${groupID}.${artifactID}. So if for some module, we couldn't migrate it to JPMS, then consumers can still use its jar as automatic module, and when we migrate it in future, consumers do not have to change the module name while specifying dependencies.
JPMS doesn't solves Version Selection problem [0] and leaves it to build tools like gradle and maven to specify version for modular dependencies. The
module-info.class
generated does contain the version associated, but isn't used -Since module names have to be unique, we need to decide on the common prefix. Some discussion on naming lucene modules - https://issues.apache.org/jira/browse/LUCENE-10255 which discusses naming lucene modules just with plain
lucene-xxxx
vsorg.apache.lucene.xxxx
. My 2 cents would be to use latter convention using full qualified name -org.opensearch.xxxx
, part of the reason related to how automatic modules are named in java. For a jar named ${groupID}-${artifactID}-${version}.jar, its automatic module would be named as ${groupID}.${artifactID}. So if for some module, we couldn't migrate it to JPMS, then consumers can still use its jar as automatic module, and when we migrate it in future, consumers do not have to change the module name while specifying dependencies.[0] - http://openjdk.java.net/projects/jigsaw/spec/reqs/02#version-selection
The text was updated successfully, but these errors were encountered: