You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Search Response processors don't use the ignoreFailure flag to do something in response of a possible failures. Instead majority of processors throw exceptions. If you take a look at the corresponding tests associated with those Response Processors tests don't incorporate asserting the ignoreFailure flag to be true.
Go to any of the following Search Reponse Processor classes and observe that ignoreFailure is not being used
Go to any test for a Search Response Processor that checks for failures (i.e. an exception is thrown) for example TruncateHitsResponseProcessorTests
run the test see it works, cahnge the ignoreFailure argument as True, The expected behavior is that its supposed to not return a exception but rather return something safe like the original SearchResponse for example. But even changing this field passes the test meaning it still returns an exception
Expected behavior
The expected behavior is that its supposed to not return a exception but rather return something safe like the original SearchResponse for example. But even changing this (ignoreField) field passes the test (i.e any test that involves throwing an exception)
Additional Details
Plugins
N/A Screenshots
N/A Host/Environment (please complete the following information):
OS: N/A
Additional context
Im currently writing a rescore(Name pending) Search Response processor and noticed that this flag is never used in the processors or the tests. I would like clarification on this detail as it ties in with what OS documentation states about ignoreFailure
The text was updated successfully, but these errors were encountered:
Speaking to engineers I learned that its not the responsibility of the Search Response Processor to handle this error instead the Search Pipeline class
Describe the bug
Search Response processors don't use the ignoreFailure flag to do something in response of a possible failures. Instead majority of processors throw exceptions. If you take a look at the corresponding tests associated with those Response Processors tests don't incorporate asserting the ignoreFailure flag to be true.
Response Processors that don’t Use ignoreFailure within the business logic (ctrl F : ignoreFailure)
CollapseResponseProcessor:
OverSampleRequestProcessor:
RenameFieldResponseProcessor(has ignoreMissing and incorporates logic):
SortResponseProcessor:
SplitResponseProcessor:
TruncateHitsResponseProcessor:
Related component
Search
To Reproduce
Expected behavior
The expected behavior is that its supposed to not return a exception but rather return something safe like the original SearchResponse for example. But even changing this (ignoreField) field passes the test (i.e any test that involves throwing an exception)
Additional Details
Plugins
N/A
Screenshots
N/A
Host/Environment (please complete the following information):
Additional context
Im currently writing a rescore(Name pending) Search Response processor and noticed that this flag is never used in the processors or the tests. I would like clarification on this detail as it ties in with what OS documentation states about ignoreFailure
The text was updated successfully, but these errors were encountered: