Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test coverage improvements] Test coverage improvement for aggregations & other search qeuries for field mapping types. #11033

Open
gashutos opened this issue Oct 31, 2023 · 1 comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations Search Search query, autocomplete ...etc

Comments

@gashutos
Copy link
Contributor

gashutos commented Oct 31, 2023

As of today, we have several types supported as a index field while creating index.
Like Int, Long, Float, half_float, sclaed_float, etc.
FieldMapper.java Gives idea about such field types. Search queries on those types have several hotpath and there are undercover paths which for which search query code path might not be exactly same. So modifying this code path might give some side effect for some data types while we improve/change some other data types.

For example, while introducing sort optimization for custom numeric types #10997, we got this nasty bug where half_float numeric type sort queries were completely broken.
Upon digging more, there aren't tests which were covering half_float basic sort queries validation.
As a part of this PR #11024, we have added that validation, but we do not have single test case for aggregation of half_float type.

I am creating this issue, to primary add integration tests for half_float aggregation search queries. But also validate for other field types and at least add basic search query tests for all field types.

@gashutos gashutos added enhancement Enhancement or improvement to existing feature or request untriaged labels Oct 31, 2023
@gashutos gashutos changed the title [Test coverage improvements] Test coverable improvement for aggregations & other search qeuries for field mapping types. [Test coverage improvements] Test coverage improvement for aggregations & other search qeuries for field mapping types. Oct 31, 2023
@ankitkala ankitkala added Search Search query, autocomplete ...etc and removed Other labels Dec 17, 2023
@macohen
Copy link
Contributor

macohen commented Dec 20, 2023

@gashutos are you looking to pick this up or looking to help someone from the community work through this? If you want it, can you assign yourself please?

@getsaurabh02 getsaurabh02 moved this from 🆕 New to Later (6 months plus) in Search Project Board Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations Search Search query, autocomplete ...etc
Projects
Status: Later (6 months plus)
Development

No branches or pull requests

4 participants