You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When working on the backport PR #10479, I found that the two test methods testParseUsingPipelineStore and innerTestParseWithProvidedPipeline never run in both main and 2.x branch, but run normally in 1.x branch, it seems that relates to the previous PR #2491 which changed the private method innerTestParseWithProvidedPipeline to public but maybe because the method name doesn't start with test so this method never runs, and also relates to PR #2239 which changed the private method innerTestParseUsingPipelineStore to public, renamed the method name but didn't remove the input parameter, so the new method testParseUsingPipelineStore also never runs.
To Reproduce
Run SimulatePipelineRequestParsingTests, you can see that only four methods are executed, testParseUsingPipelineStore and innerTestParseWithProvidedPipeline never run.
Expected behavior
Enable the two test methods.
Screenshots
Host/Environment (please complete the following information):
OS: [macOS]
Version [3.0]
The text was updated successfully, but these errors were encountered:
After renaming innerTestParseWithProvidedPipeline to testParseWithProvidedPipeline and removing the input parameter of testParseUsingPipelineStore, the two methods runs well.
Describe the bug
When working on the backport PR #10479, I found that the two test methods
testParseUsingPipelineStore
andinnerTestParseWithProvidedPipeline
never run in both main and 2.x branch, but run normally in 1.x branch, it seems that relates to the previous PR #2491 which changed the private methodinnerTestParseWithProvidedPipeline
to public but maybe because the method name doesn't start withtest
so this method never runs, and also relates to PR #2239 which changed the private methodinnerTestParseUsingPipelineStore
to public, renamed the method name but didn't remove the input parameter, so the new methodtestParseUsingPipelineStore
also never runs.Here are the detail of the related changes:
innerTestParseWithProvidedPipeline
testParseUsingPipelineStore
To Reproduce
Run
SimulatePipelineRequestParsingTests
, you can see that only four methods are executed,testParseUsingPipelineStore
andinnerTestParseWithProvidedPipeline
never run.Expected behavior
Enable the two test methods.
Screenshots
Host/Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: