Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some test methods in SimulatePipelineRequestParsingTests never run #10493

Closed
gaobinlong opened this issue Oct 7, 2023 · 2 comments
Closed
Labels
bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing untriaged

Comments

@gaobinlong
Copy link
Collaborator

Describe the bug
When working on the backport PR #10479, I found that the two test methods testParseUsingPipelineStore and innerTestParseWithProvidedPipeline never run in both main and 2.x branch, but run normally in 1.x branch, it seems that relates to the previous PR #2491 which changed the private method innerTestParseWithProvidedPipeline to public but maybe because the method name doesn't start with test so this method never runs, and also relates to PR #2239 which changed the private method innerTestParseUsingPipelineStore to public, renamed the method name but didn't remove the input parameter, so the new method testParseUsingPipelineStore also never runs.

Here are the detail of the related changes:

innerTestParseWithProvidedPipeline

testParseUsingPipelineStore

To Reproduce
Run SimulatePipelineRequestParsingTests, you can see that only four methods are executed, testParseUsingPipelineStore and innerTestParseWithProvidedPipeline never run.

Expected behavior
Enable the two test methods.

Screenshots
image

Host/Environment (please complete the following information):

  • OS: [macOS]
  • Version [3.0]
@gaobinlong gaobinlong added bug Something isn't working untriaged labels Oct 7, 2023
@gaobinlong
Copy link
Collaborator Author

After renaming innerTestParseWithProvidedPipeline to testParseWithProvidedPipeline and removing the input parameter of testParseUsingPipelineStore, the two methods runs well.

image

@msfroh msfroh added the Indexing Indexing, Bulk Indexing and anything related to indexing label Oct 9, 2023
@dblock
Copy link
Member

dblock commented Oct 10, 2023

Closed via #10496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing untriaged
Projects
None yet
Development

No branches or pull requests

3 participants