Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracing Instrumentation] Add instrumentation for OpenSearch tasks management #10293

Closed
Tracked by #7542
Gaganjuneja opened this issue Oct 2, 2023 · 5 comments
Closed
Tracked by #7542
Labels
Cluster Manager distributed framework enhancement Enhancement or improvement to existing feature or request untriaged

Comments

@Gaganjuneja
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Add instrumentation generically for the task management so that all the tasks will be instrumented by default.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Shephalimittal
Copy link
Contributor

To instrument Task manager layer,

Start span can be added in TaskManager.register() method here

End span can be added in TaskManager.unregister() method here

Thoughts?

@Shephalimittal
Copy link
Contributor

@reta Thoughts on above?

@reta
Copy link
Collaborator

reta commented Jan 24, 2024

@reta Thoughts on above?

I am not sure this is a simple as that:

  • TaskManager#register is an entry point, probably make sense to capture the parent span here
  • TaskManager#unregister is one of the way task could marked as completed
  • TaskManager#cancel is another way task could marked as completed (but cancelled)

May be there are other things I am missing.

@Gaganjuneja
Copy link
Contributor Author

@reta Thoughts on above?

I am not sure this is a simple as that:

  • TaskManager#register is an entry point, probably make sense to capture the parent span here
  • TaskManager#unregister is one of the way task could marked as completed
  • TaskManager#cancel is another way task could marked as completed (but cancelled)

May be there are other things I am missing.

These are good starting points. We can get to know more once we start diving deep.

@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5]
@Gaganjuneja Thanks for creating this issue; however, it isn't being accepted due to not having clear detail on what should be done and what done looks like. Please feel free to open a new issue after addressing the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cluster Manager distributed framework enhancement Enhancement or improvement to existing feature or request untriaged
Projects
None yet
Development

No branches or pull requests

6 participants