From c93d086d46b986eb28b81e982ad6011785f937ee Mon Sep 17 00:00:00 2001
From: Poojita Raj <poojiraj@amazon.com>
Date: Thu, 24 Aug 2023 09:29:08 -0700
Subject: [PATCH] add test

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
---
 .../allocation/FailedNodeRoutingTests.java    | 37 +++++++++++++++----
 1 file changed, 30 insertions(+), 7 deletions(-)

diff --git a/server/src/test/java/org/opensearch/cluster/routing/allocation/FailedNodeRoutingTests.java b/server/src/test/java/org/opensearch/cluster/routing/allocation/FailedNodeRoutingTests.java
index 80afc1d9b0b0f..c245e608edbec 100644
--- a/server/src/test/java/org/opensearch/cluster/routing/allocation/FailedNodeRoutingTests.java
+++ b/server/src/test/java/org/opensearch/cluster/routing/allocation/FailedNodeRoutingTests.java
@@ -53,6 +53,7 @@
 import org.opensearch.cluster.routing.allocation.decider.ClusterRebalanceAllocationDecider;
 import org.opensearch.common.settings.Settings;
 import org.opensearch.indices.cluster.ClusterStateChanges;
+import org.opensearch.indices.replication.common.ReplicationType;
 import org.opensearch.test.VersionUtils;
 import org.opensearch.threadpool.TestThreadPool;
 import org.opensearch.threadpool.ThreadPool;
@@ -69,6 +70,7 @@
 
 import static org.opensearch.cluster.metadata.IndexMetadata.SETTING_NUMBER_OF_REPLICAS;
 import static org.opensearch.cluster.metadata.IndexMetadata.SETTING_NUMBER_OF_SHARDS;
+import static org.opensearch.cluster.metadata.IndexMetadata.SETTING_REPLICATION_TYPE;
 import static org.opensearch.cluster.routing.ShardRoutingState.INITIALIZING;
 import static org.opensearch.cluster.routing.ShardRoutingState.STARTED;
 import static org.hamcrest.Matchers.equalTo;
@@ -137,7 +139,15 @@ public void testSimpleFailedNodeTest() {
         }
     }
 
+    public void testRandomClusterPromotesOldestReplica() throws InterruptedException {
+        testRandomClusterPromotesReplica(true);
+    }
+
     public void testRandomClusterPromotesNewestReplica() throws InterruptedException {
+        testRandomClusterPromotesReplica(false);
+    }
+
+    void testRandomClusterPromotesReplica(boolean isSegmentReplicationEnabled) throws InterruptedException {
 
         ThreadPool threadPool = new TestThreadPool(getClass().getName());
         ClusterStateChanges cluster = new ClusterStateChanges(xContentRegistry(), threadPool);
@@ -164,6 +174,9 @@ public void testRandomClusterPromotesNewestReplica() throws InterruptedException
             Settings.Builder settingsBuilder = Settings.builder()
                 .put(SETTING_NUMBER_OF_SHARDS, randomIntBetween(1, 4))
                 .put(SETTING_NUMBER_OF_REPLICAS, randomIntBetween(2, 4));
+            if (isSegmentReplicationEnabled) {
+                settingsBuilder.put(SETTING_REPLICATION_TYPE, ReplicationType.SEGMENT);
+            }
             CreateIndexRequest request = new CreateIndexRequest(name, settingsBuilder.build()).waitForActiveShards(ActiveShardCount.NONE);
             state = cluster.createIndex(state, request);
             assertTrue(state.metadata().hasIndex(name));
@@ -206,13 +219,23 @@ public void testRandomClusterPromotesNewestReplica() throws InterruptedException
                     Version candidateVer = getNodeVersion(sr, compareState);
                     if (candidateVer != null) {
                         logger.info("--> candidate on {} node; shard routing: {}", candidateVer, sr);
-                        assertTrue(
-                            "candidate was not on the newest version, new primary is on "
-                                + newPrimaryVersion
-                                + " and there is a candidate on "
-                                + candidateVer,
-                            candidateVer.onOrBefore(newPrimaryVersion)
-                        );
+                        if (isSegmentReplicationEnabled) {
+                            assertTrue(
+                                "candidate was not on the oldest version, new primary is on "
+                                    + newPrimaryVersion
+                                    + " and there is a candidate on "
+                                    + candidateVer,
+                                candidateVer.onOrAfter(newPrimaryVersion)
+                            );
+                        } else {
+                            assertTrue(
+                                "candidate was not on the newest version, new primary is on "
+                                    + newPrimaryVersion
+                                    + " and there is a candidate on "
+                                    + candidateVer,
+                                candidateVer.onOrBefore(newPrimaryVersion)
+                            );
+                        }
                     }
                 });
             });