From adfeca87b1b4206e4ce05647cc584ad5b477f0ff Mon Sep 17 00:00:00 2001 From: Kuanysh Aimurzinov Date: Wed, 21 Jun 2023 11:48:07 +0600 Subject: [PATCH] code refactoring Signed-off-by: Kuanysh Aimurzinov --- .../settings/AbstractScopedSettings.java | 2 +- ...dSettingsUpdateConsumerRequestHandler.java | 21 +++++++++---------- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/server/src/main/java/org/opensearch/common/settings/AbstractScopedSettings.java b/server/src/main/java/org/opensearch/common/settings/AbstractScopedSettings.java index 435f507fc1e40..8b7a2a82e5cb1 100644 --- a/server/src/main/java/org/opensearch/common/settings/AbstractScopedSettings.java +++ b/server/src/main/java/org/opensearch/common/settings/AbstractScopedSettings.java @@ -249,7 +249,7 @@ public synchronized void addSettingsUpdateConsumer(Setting setting, Consu throw new SettingsException("Setting is not registered for key [" + setting.getKey() + "]"); } addSettingsUpdater(setting.newUpdater(consumer, logger, validator)); - } + } /** * Adds a settings consumer that is only executed if any setting in the supplied list of settings is changed. In that case all the diff --git a/server/src/main/java/org/opensearch/extensions/AddSettingsUpdateConsumerRequestHandler.java b/server/src/main/java/org/opensearch/extensions/AddSettingsUpdateConsumerRequestHandler.java index 3f1e6a88857fa..b465ed389846c 100644 --- a/server/src/main/java/org/opensearch/extensions/AddSettingsUpdateConsumerRequestHandler.java +++ b/server/src/main/java/org/opensearch/extensions/AddSettingsUpdateConsumerRequestHandler.java @@ -87,17 +87,16 @@ TransportResponse handleAddSettingsUpdateConsumerRequest(AddSettingsUpdateConsum // Register setting update consumer with callback method to extension if (setting.hasIndexScope()) { - clusterService.getClusterSettings() - .addSettingsUpdateConsumer(settingForUpdateConsumer, (data) -> { - logger.debug("Sending extension request type: " + updateSettingsRequestType); - UpdateSettingsResponseHandler updateSettingsResponseHandler = new UpdateSettingsResponseHandler(); - transportService.sendRequest( - extensionNode, - updateSettingsRequestType, - new UpdateSettingsRequest(settingType, setting, data), - updateSettingsResponseHandler - ); - }); + clusterService.getClusterSettings().addSettingsUpdateConsumer(settingForUpdateConsumer, (data) -> { + logger.debug("Sending extension request type: " + updateSettingsRequestType); + UpdateSettingsResponseHandler updateSettingsResponseHandler = new UpdateSettingsResponseHandler(); + transportService.sendRequest( + extensionNode, + updateSettingsRequestType, + new UpdateSettingsRequest(settingType, setting, data), + updateSettingsResponseHandler + ); + }); } if (setting.hasNodeScope()) { clusterService.getClusterSettings()