-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leaflet-vega and vega-interpreter mismatch in yarn.lock file #2432
Fix leaflet-vega and vega-interpreter mismatch in yarn.lock file #2432
Conversation
da5e8ae
to
1f76f5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
1f76f5d
to
32dfc1d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2432 +/- ##
==========================================
- Coverage 66.76% 66.74% -0.02%
==========================================
Files 3196 3196
Lines 60813 60813
Branches 9240 9240
==========================================
- Hits 40600 40592 -8
- Misses 18006 18012 +6
- Partials 2207 2209 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: abbyhu2000 <[email protected]>
32dfc1d
to
babbc9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am aware of this. It is a mismatch from previous PR. Thanks for fixing this.
I think you just need to update this file: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CHANGELOG.md
Ashwin and Josh mentioned in a previous comment that this PR prob does not need to be added to the CHANGELOG.md file so i removed it from CHANGELOG.md file. |
Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>
Signed-off-by: abbyhu2000 [email protected]
Description
Updated yarn.lock file for leaflet-vega and vega-interpreter package.
Seem like there is a version mismatch between package.json and yarn.lock in this commit in PR: #2352
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr