Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaflet-vega and vega-interpreter mismatch in yarn.lock file #2432

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

abbyhu2000
Copy link
Member

Signed-off-by: abbyhu2000 [email protected]

Description

Updated yarn.lock file for leaflet-vega and vega-interpreter package.
Seem like there is a version mismatch between package.json and yarn.lock in this commit in PR: #2352

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000 abbyhu2000 marked this pull request as ready for review September 28, 2022 19:48
@abbyhu2000 abbyhu2000 requested a review from a team as a code owner September 28, 2022 19:48
@abbyhu2000 abbyhu2000 self-assigned this Sep 28, 2022
joshuarrrr
joshuarrrr previously approved these changes Sep 28, 2022
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #2432 (32dfc1d) into main (83f1306) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2432      +/-   ##
==========================================
- Coverage   66.76%   66.74%   -0.02%     
==========================================
  Files        3196     3196              
  Lines       60813    60813              
  Branches     9240     9240              
==========================================
- Hits        40600    40592       -8     
- Misses      18006    18012       +6     
- Partials     2207     2209       +2     
Impacted Files Coverage Δ
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (-2.78%) ⬇️
...ared/static/forms/hook_form_lib/hooks/use_field.ts 65.70% <0.00%> (-0.97%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: abbyhu2000 <[email protected]>
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware of this. It is a mismatch from previous PR. Thanks for fixing this.

I think you just need to update this file: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CHANGELOG.md

@abbyhu2000
Copy link
Member Author

I am aware of this. It is a mismatch from previous PR. Thanks for fixing this.

I think you just need to update this file: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CHANGELOG.md

Ashwin and Josh mentioned in a previous comment that this PR prob does not need to be added to the CHANGELOG.md file so i removed it from CHANGELOG.md file.

@abbyhu2000 abbyhu2000 merged commit 4078721 into opensearch-project:main Sep 29, 2022
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
@abbyhu2000 abbyhu2000 deleted the fix_yarn_lock_file branch June 30, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants