From 1403d242d9ebbda0e73105cbeafad46b74cefb64 Mon Sep 17 00:00:00 2001 From: Kawika Avilla Date: Thu, 23 Jun 2022 08:48:15 +0000 Subject: [PATCH] [CI] Bump chromedriver to 102 GitHub env runs on Chrome 102. This is done to get the CI working again on 1.x however there is a follow-up issue here: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/1746 However, there's an issue with Node existing on an a user that the GitHub CI doesn't have permissions too. Issue: n/a Signed-off-by: Kawika Avilla --- .github/workflows/pr_check_workflow.yml | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/.github/workflows/pr_check_workflow.yml b/.github/workflows/pr_check_workflow.yml index 3f676abf831a..68fb848d359c 100644 --- a/.github/workflows/pr_check_workflow.yml +++ b/.github/workflows/pr_check_workflow.yml @@ -95,20 +95,6 @@ jobs: - run: echo Unit tests completed unsuccessfully. However, unit tests are inconsistent on the CI so please verify locally with `yarn test:jest`. if: steps.unit_tests_results.outputs.unit_tests_results != 'success' && steps.unit-tests.outcome != 'success' - - # TODO: This gets rejected, we need approval to add this - # - name: Add comment if unit tests did not succeed - # if: steps.unit_tests_results.outputs.unit_tests_results != 'success' && steps.unit-tests.outcome != 'success' - # uses: actions/github-script@v5 - # with: - # github-token: ${{ secrets.GITHUB_TOKEN }} - # script: | - # github.rest.issues.createComment({ - # issue_number: context.issue.number, - # owner: context.repo.owner, - # repo: context.repo.repo, - # body: 'Unit tests completed unsuccessfully. However, unit tests are inconsistent on the CI so please verify locally with `yarn test:jest`.' - # }) - name: Run integration tests if: steps.integration_tests_results.outputs.integration_tests_results != 'success' @@ -190,7 +176,7 @@ jobs: # github virtual env is the latest chrome - name: Setup chromedriver if: steps.ftr_tests_results.outputs.ftr_tests_results != 'success' - run: yarn add --dev chromedriver@100.0.0 + run: yarn add --dev chromedriver@102.0.0 - name: Run bootstrap if: steps.ftr_tests_results.outputs.ftr_tests_results != 'success'