Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS] Support label rendering when only given ID #6274

Closed
1 of 2 tasks
Tracked by #5872
derek-ho opened this issue Mar 26, 2024 · 4 comments
Closed
1 of 2 tasks
Tracked by #5872

[MDS] Support label rendering when only given ID #6274

derek-ho opened this issue Mar 26, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.14.0

Comments

@derek-ho
Copy link
Contributor

derek-ho commented Mar 26, 2024

To support a more seamless MDS experience, plugins may want to include the dataSourceId within the url somehow. Thus, links can be shared with the correct datasource context. However, today the datasource menu does not populate the label of the datasource based on the datasource. This can be confusing to users, who may not know what human-readable datasource they are looking at.

We should support this for all types of components(read only, selectable, aggregate), when activeOption is provided.

Either an API call should be made to look up the datasource name, or it can be attempted to be found using the existing list that gets called by the menu component initially.

For illegal data source id passed into the component, we should show a toast with user friendly message like Data source <id> is not available.

@derek-ho derek-ho added the enhancement New feature or request label Mar 26, 2024
@BionIT
Copy link
Collaborator

BionIT commented Mar 26, 2024

Thanks @derek-ho! One discussion we had with @RamakrishnaChilaka as well was that if only the data source id is provided, then the component will make a call to get the name/title of the data source to save some network calls.

@yujin-emma yujin-emma self-assigned this Mar 26, 2024
@yujin-emma
Copy link
Contributor

I will work on this :)

@BionIT BionIT added multiple datasource multiple datasource project v2.14.0 and removed untriaged labels Mar 26, 2024
@BionIT
Copy link
Collaborator

BionIT commented Mar 26, 2024

Thanks @yujin-emma

@BionIT
Copy link
Collaborator

BionIT commented Apr 22, 2024

PR has been merged, closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.14.0
Projects
None yet
Development

No branches or pull requests

3 participants