Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource] Refactor data source menu and clean up data source component configurations #6239

Closed
Tracked by #5872
BionIT opened this issue Mar 21, 2024 · 1 comment · Fixed by #6256
Closed
Tracked by #5872
Labels
multiple datasource multiple datasource project refactor Tech debt related tasks that need refactoring technical debt If not paid, jeapardizes long-term success and maintainability of the repository. v2.14.0

Comments

@BionIT
Copy link
Collaborator

BionIT commented Mar 21, 2024

In #6082, we introduced a data source menu component which acts as a higher level component and rely on the props passed by plugins to determine which component to mount onto the navigation bar.

The components to be rendered are mutually exclusive, and having multiple boolean properties makes it hard to maintain, thus we should switch to a new structure to render the following component:

  • DataSourceView
  • DataSourceAggregatedView
  • DataSourceSelectable
  • DataSourceMultiSelectable (to be added)
@BionIT BionIT added untriaged refactor Tech debt related tasks that need refactoring technical debt If not paid, jeapardizes long-term success and maintainability of the repository. labels Mar 21, 2024
@seraphjiang seraphjiang added the multiple datasource multiple datasource project label Mar 22, 2024
@seraphjiang
Copy link
Member

seraphjiang commented Mar 22, 2024

data source menu component

could developer use those components directly?

between <DataSourceMenu component=DataSourceSelectable> and <DataSourceSelectable />, are there lots of benefit to create a wrap component

@BionIT BionIT changed the title [Multiple Datasource] Instead of having multiple boolean props to determine the appearance of the component, enum can be used in combination with switch statement [Multiple Datasource] Refactor data source menu and clean up data source component configurations Mar 24, 2024
@BionIT BionIT added the v2.14.0 label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple datasource multiple datasource project refactor Tech debt related tasks that need refactoring technical debt If not paid, jeapardizes long-term success and maintainability of the repository. v2.14.0
Projects
None yet
3 participants