You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In #6082, we introduced a new component which takes advantage of setMountPoint exposed by MountPointPortal to mount it to the navigation bar - big thanks to @ashwin-pc for providing the suggestions. The problem we found is in the Maps plugin, it will override the TopNavMenu if there is any since it uses the same mount point.
Describe the solution you'd like
We should keep the TopNavMenu while mount the data source menu into the navigation bar, there are 2 options:
use TopNavMenu as the top component for all data source components, and drawback is then it needs to expose properties that is only meaningful for data source components
Option 3:
mount both topNavMenu and data source menu for Maps, and topNavMenu will still render the search bars, while data source menu will render the menu buttons to be mount by topNavMenu
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
If they are already using the TopNavMenu component, then they can just add a new menu item to its config prop. the suggestion to use setMountPoint was for plugins that dont already use the TopNavMenu component :)
Based on discussion on 3/21/2024 with @ashwin-pc@Flyingliuhub@ZilongX@yujin-emma , we will add a boolean in TopNavMenu and a top level data source menu props in the TopNavMenu component to allow rendering data source menu together with top nav menu. This will allow Maps plugin that already uses top nav menu to mount both menu at the same navigation bar without overriding each other.
Is your feature request related to a problem? Please describe.
In #6082, we introduced a new component which takes advantage of setMountPoint exposed by MountPointPortal to mount it to the navigation bar - big thanks to @ashwin-pc for providing the suggestions. The problem we found is in the Maps plugin, it will override the TopNavMenu if there is any since it uses the same mount point.
Describe the solution you'd like
We should keep the TopNavMenu while mount the data source menu into the navigation bar, there are 2 options:
Option 1:
Option 2:
Option 3:
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: