[Multi data Source] Data source and Data source management plugin auditing

[bandinib-amzn]

Issue Description

Perform a general audit of the data source and data source management plugin.

Proposed Implementation

1. Ensure near 100% coverage of documentation.
2. Ensure that there is documentation coverage of the backend and its functions.
3. Perform a static code analysis, and address issues that it finds.
   3.1 Ensure that best practices are followed.
   3.2 Fix typo errors.
   3.3 Remove duplicate code
   3.4 Naming of methods, parameters should be adherent to their functionality.
   3.5 Correct TypeScript type errors
4. Ensure near 100% coverage of Unit testing
5. Add functional. integration tests
6. Search for security vulnerabilities.

Tasks

• [MDS]Typo in data_source_management plugin #6142
• [Multiple Datasource] Move data source selectable to its own folder, fix test and a few type errors for data source selectable component #6287
• Remove duplicate data source attribute interface #6437

[seraphjiang]

Thanks @bandinib-amzn for taking the initiative to raise the bar for the quality.

[bandinib-amzn]

Data source plugin and data source management plugin both have data source attribute interface.

Interface in data source plugin:

OpenSearch-Dashboards/src/plugins/data_source/common/data_sources/types.ts

Lines 8 to 18 in 476cffc

	export interface DataSourceAttributes extends SavedObjectAttributes {
	title: string;
	description?: string;
	endpoint: string;
	auth: {
	type: AuthType;
	credentials: UsernamePasswordTypedContent | SigV4Content | undefined | AuthTypeContent;
	};
	lastUpdatedTime?: string;
	name: AuthType | string;
	}

Interface in data source management plugin:

OpenSearch-Dashboards/src/plugins/data_source_management/public/types.ts

Lines 139 to 153 in 476cffc

	export interface DataSourceAttributes extends SavedObjectAttributes {
	title: string;
	description?: string;
	endpoint?: string;
	dataSourceVersion?: string;
	installedPlugins?: string[];
	auth: {
	type: AuthType | string;
	credentials:
	| UsernamePasswordTypedContent
	| SigV4Content
	| { [key: string]: string }
	| undefined;
	};
	}

It creates confusion among the plugin owners and in general consumers of data source plugin. Therefore, we should maintain only one interface for data source attributes.

I propose to remove interface from data_source_management[https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data_source_management/].

• Move extra properties to interface in data_source plugin.
• change type of auth_type to be AuthType | string to allow custom auth type along with predefined.
• To reduce impact and efforts to change reference in files which are using data_source_management plugin interface, we will export the interface from the same file from where we removed duplicate interface.