-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Import sample data to specific workspace #6106
Comments
There are two parts for sample data
could we elaborate a little bit, which part is broken |
Hi @seraphjiang, my issue was not clear. I'm very apologize for this. |
@wanglam Can we resolve this issue? |
Sure, since import sample data to workspace has been added in #6105 . We can close this issue. |
Is your feature request related to a problem? Please describe.
When workspace plugin enabled, current import sample data feature will be break if you're in a specific workspace. The sample data won't be import to current workspace. The imported index patterns and dashboards won't be displayed. TheAdd data
button will be hidden and theRemove
button will always be displayed if user import sample data before.The import sample data page is a sub page under home application. For now the home application is not visible inside specific workspace. So there is no entry for importing sample data page after enter specific workspace. It's not convenient for user to experience workspace features. It would be very valuable to add an entry for importing data in the workspace overview page.
Describe the solution you'd like
1. Pass current workspace id to import sample data install / uninstall / list API2. Refactor
getDataSourceIntegratedDashboard
togetDashboardWithPrefix
, support passing workspace id when checkingoverviewDashboard
id.3. Add
getWorkspaceIntegratedSavedObjects
, generate sample data with workspace id when installing and uninstallinggetDataSourceIntegratedDashboard
getDataSourceIntegratedDefaultIndex
Describe alternatives you've considered
N/A
Additional context
#4944
The text was updated successfully, but these errors were encountered: