Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Expose properties to allow customization for picker provided by data source plugin #5992

Closed
Tracked by #5752
BionIT opened this issue Mar 1, 2024 · 1 comment · Fixed by #6057
Closed
Tracked by #5752
Assignees
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.13.0

Comments

@BionIT
Copy link
Collaborator

BionIT commented Mar 1, 2024

Is your feature request related to a problem? Please describe.

In #5717, we implemented a data source picker in order to unify the experience when selecting data source in devtools, tutorial, etc. While being used by plugins, this picker needs to be customized in order to satisfy the needs.

Describe the solution you'd like

We can expose the following properties for consumers

  • placeholderText
  • prepend
  • defaultOption

In addition, we can expose a filter function property to allow consumers to define their filtering logic to hide incompatible/irrelevant data sources

Describe alternatives you've considered
Each consumer would need to write its own picker in order to customize things

Additional context

Add any other context or screenshots about the feature request here.

@BionIT BionIT added the enhancement New feature or request label Mar 1, 2024
@BionIT BionIT added multiple datasource multiple datasource project and removed untriaged labels Mar 1, 2024
@BionIT BionIT self-assigned this Mar 1, 2024
@seraphjiang
Copy link
Member

looking forward to see some examples. It could be first party plugin like discover app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.13.0
Projects
None yet
3 participants