Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Implement Registration Function for Dynamic NavLink Management #5608

Open
willie-hung opened this issue Dec 13, 2023 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@willie-hung
Copy link
Contributor

willie-hung commented Dec 13, 2023

Problem statement

Currently, the management of active navigation links relies on hard-coded logic. This approach limits flexibility, as seen in the current implementation:
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/478176ab553045e7e8e7b515f6c55b46e2bff2d4/src/core/public/chrome/ui/header/nav_link.tsx#L42C1-L48C70

This issue is also discussed in PR #5432 and Issue #5226.

after.mov

Proposed solution

To enhance flexibility and allow for more dynamic management of navigation links, a registration function should be implemented. This function will enable individual apps within OpenSearch Dashboards to control their active navigation links.

@willie-hung willie-hung added the enhancement New feature or request label Dec 13, 2023
@joshuarrrr
Copy link
Member

Just a further note here that these nav behaviors are very similar to breadcrumb functionality, so as much as possible we should follow the existing breadcrumb registration patterns.

@ashwin-pc ashwin-pc added the good first issue Good for newcomers label Feb 20, 2024
@subhanahujha007
Copy link

/attempt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants