-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore devDependencies version mismatch in bootstrap #5561
Comments
@kavilla / @ashwin-pc I saw that there was some discussion about this before, but I wasn't able to find a resolution - can you advise here on if there is a fix from core side or we should just try to manually match the |
#3095 I found this RFC on decoupling the dependency. |
Thanks, @abbyhu2000, @AMoo-Miki! Would it be feasible to fix this from dashboards side in near term, or should I still open issues in individual plugin repos to manually match the versions? |
@derek-ho According the opensearch-build script, it will remove the success build plugin folder if everything goes well. According the build log, the root cause was dashboards-reporting build failed due to failed to run |
@AMoo-Miki 's PR #5675 should allow for less restrictive version requirements. |
@ashwin-pc @AMoo-Miki any updates on this issue long term? We started seeing failures on bootstrap on
Any suggestions on path forward to unblock the CI/autocuts? |
Update: adding |
@ashwin-pc @AMoo-Miki Could you take a look at a pull request [1] in opensearch-build to make this the default for the distribution build process? |
OSD 2.12 shipped with #5675. Infra will take care of the PR on the build repo. |
Is your feature request related to a problem? Please describe.
Security dashboards plugin was recently cut a ticket for a build failure: opensearch-project/security-dashboards-plugin#1682 (comment). Locally, matching the version in package.json solves this type of issue, but not sure if this is scalable long term, and especially for devDependencies matching the version should matter less?
Describe the solution you'd like
Ignore/skip/provide some other long term solution for dependency resolution/matching
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: