Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase augment-vis saved obj limits on a dashboard #4593

Closed
ohltyler opened this issue Jul 19, 2023 · 0 comments · Fixed by #4595
Closed

Increase augment-vis saved obj limits on a dashboard #4593

ohltyler opened this issue Jul 19, 2023 · 0 comments · Fixed by #4595
Assignees

Comments

@ohltyler
Copy link
Member

ohltyler commented Jul 19, 2023

By default, the saved object loader findAll() has a limit of 100 objects and doesn't implement pagination, as that is an open/incomplete item on OSD side. Because of this, there is a default limitation of 100 objects (associations) that we can show on a given dashboard when all of them are fetched.

Saved object loader findAll(): https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/saved_objects/public/saved_object/saved_object_loader.ts#L122-L147
Augment vis saved object loader findAll() (just a super call): https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/vis_augmenter/public/saved_augment_vis/saved_augment_vis.ts#L85-L97

A few options to improve this:

  1. Add other search fields to findAll() call so we only fetch the objs for a particular vis ID. This is because right now, we are making this call for each visualization, fetching all of the same objs, and then doing post-filtering to only include ones that match the vis ID. This is inefficient and adds unnecessary network load
  2. Increase the base size limit of 100 to something larger. Depending on what we want to support per visualization, and if the first option is completed first, perhaps 100 is sufficient.
  3. Implement pagination at the base saved object loader level.

Option 1 will likely be sufficient to solve the problems. If we end up wanting to support >100 associations per vis, we can look into Options 2/3

@ohltyler ohltyler changed the title Increase augment-vis limits Increase augment-vis saved obj limits on a dashboard Jul 19, 2023
@ohltyler ohltyler self-assigned this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant