You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By default, the saved object loader findAll() has a limit of 100 objects and doesn't implement pagination, as that is an open/incomplete item on OSD side. Because of this, there is a default limitation of 100 objects (associations) that we can show on a given dashboard when all of them are fetched.
Add other search fields to findAll() call so we only fetch the objs for a particular vis ID. This is because right now, we are making this call for each visualization, fetching all of the same objs, and then doing post-filtering to only include ones that match the vis ID. This is inefficient and adds unnecessary network load
Increase the base size limit of 100 to something larger. Depending on what we want to support per visualization, and if the first option is completed first, perhaps 100 is sufficient.
Implement pagination at the base saved object loader level.
Option 1 will likely be sufficient to solve the problems. If we end up wanting to support >100 associations per vis, we can look into Options 2/3
The text was updated successfully, but these errors were encountered:
By default, the saved object loader
findAll()
has a limit of 100 objects and doesn't implement pagination, as that is an open/incomplete item on OSD side. Because of this, there is a default limitation of 100 objects (associations) that we can show on a given dashboard when all of them are fetched.Saved object loader
findAll()
: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/saved_objects/public/saved_object/saved_object_loader.ts#L122-L147Augment vis saved object loader
findAll()
(just asuper
call): https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/vis_augmenter/public/saved_augment_vis/saved_augment_vis.ts#L85-L97A few options to improve this:
findAll()
call so we only fetch the objs for a particular vis ID. This is because right now, we are making this call for each visualization, fetching all of the same objs, and then doing post-filtering to only include ones that match the vis ID. This is inefficient and adds unnecessary network loadOption 1 will likely be sufficient to solve the problems. If we end up wanting to support >100 associations per vis, we can look into Options 2/3
The text was updated successfully, but these errors were encountered: