Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Replace/Rewrite HTML table in DocViewTable with Oui Component #4470

Closed
ananzh opened this issue Jun 30, 2023 · 0 comments
Closed
Assignees
Labels
data explorer Issues related to the Data Explorer project

Comments

@ananzh
Copy link
Member

ananzh commented Jun 30, 2023

DocViewTable is using custom HTML table implementation with the standard HTML tags for defining tables, including <table>, <tbody> and <tr>. Should replace it with Oui component, like EuiDataGrid, EuiInMemoryTable or EuiBasicTable for consistent and maintenance purpose. Since our purpose is not for displaying tabular data and we don't need features like sorting, resizable column, full screen mode and don't have customized cell rendering, I think EuiDataGrid might be over-kill. I vote for EuiInMemoryTable or EuiBasicTable.

@ananzh ananzh added bug Something isn't working untriaged and removed bug Something isn't working untriaged labels Jun 30, 2023
@ananzh ananzh added the data explorer Issues related to the Data Explorer project label Jun 30, 2023
@ananzh ananzh self-assigned this Jun 30, 2023
@ananzh ananzh removed the untriaged label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project
Projects
None yet
Development

No branches or pull requests

2 participants