Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis colors] Update default color in TSVB to use ouiPaletteColorBlind()[0] #4324

Closed
Tracked by #4318
joshuarrrr opened this issue Jun 19, 2023 · 1 comment
Closed
Tracked by #4318

[Vis colors] Update default color in TSVB to use ouiPaletteColorBlind()[0] #4324

joshuarrrr opened this issue Jun 19, 2023 · 1 comment
Assignees
@manasvinibs
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks unified visualization UX

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Jun 19, 2023 •
edited
Loading

The TSVB visualization (vis_type_timeseries plugin) uses #68BC00 as the default color for a single-series: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/vis_type_timeseries/public/metrics_type.ts#L56

Instead, it should use the first color from euiPaletteColorBlind().

see opensearch-project/oui#601 for visual comparison
@joshuarrrr joshuarrrr mentioned this issue Jun 19, 2023
Open
17 tasks
@joshuarrrr joshuarrrr added unified visualization UX OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks labels Jun 19, 2023
@joshuarrrr joshuarrrr moved this to Todo in Look & Feel Jun 19, 2023
@manasvinibs manasvinibs mentioned this issue Jun 22, 2023
Merged
8 tasks
@joshuarrrr
Copy link
Member Author

completed via #4363

@github-project-automation github-project-automation bot moved this from Todo to Done in Look & Feel Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manasvinibs manasvinibs

Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks unified visualization UX
Projects
Look & Feel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshuarrrr @manasvinibs