Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] [CCI] console Audit. Unused ul html element. #3992

Closed
curq opened this issue May 8, 2023 · 2 comments
Closed

[Console] [CCI] console Audit. Unused ul html element. #3992

curq opened this issue May 8, 2023 · 2 comments
Labels
bug Something isn't working OUI Issues that require migration to OUI

Comments

@curq
Copy link
Collaborator

curq commented May 8, 2023

Describe the bug

After doing audit of console plugin. I noticed <ul> element and its scss class that were never used and that they don't seem to do anything.

// SASSTODO: This component seems to not be used anymore?
// Possibly replaced by the Ace version
.conApp__autoComplete {
position: absolute;
left: -1000px;
visibility: hidden;
/* by pass any other element in ace and resize bar, but not modal popups */
z-index: $euiZLevel1 + 2;
margin-top: 22px;
}


Expected behavior
No redundant custom styling or native html elements

Dashboards Version
2.7.0

Plugins

Console plugin

Additional context

We can see from the comments left by previous developers in the .scss file that they also didn't find if the removed element and styling were used anymore.

@curq curq added bug Something isn't working untriaged labels May 8, 2023
@joshuarrrr joshuarrrr added the OUI Issues that require migration to OUI label May 23, 2023
@joshuarrrr joshuarrrr moved this to Done in Look & Feel May 23, 2023
@joshuarrrr
Copy link
Member

@curq This is complete via #3993, right?

@curq
Copy link
Collaborator Author

curq commented May 23, 2023

@joshuarrrr Yes, you are right

@curq curq closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OUI Issues that require migration to OUI
Projects
Status: Done
Development

No branches or pull requests

2 participants