Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Remove dependency on 'TinyMath' #3655

Closed
2 tasks done
abbyhu2000 opened this issue Mar 22, 2023 · 2 comments · Fixed by #4492
Closed
2 tasks done

[Tech Debt] Remove dependency on 'TinyMath' #3655

abbyhu2000 opened this issue Mar 22, 2023 · 2 comments · Fixed by #4492
Assignees
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@abbyhu2000
Copy link
Member

abbyhu2000 commented Mar 22, 2023

Tinymath is a lightweight and fast JavaScript library for performing mathematical operations in JavaScript. It provides a range of mathematical functions for working with numbers, such as addition, subtraction, multiplication, division, and more.

However, we should replace tinymath since it is abandoned 4 years ago and it contributes to the CSP-related vulnerability of OSD.

Current dependency: "tinymath": "1.2.1"

Subtasks:

@abbyhu2000 abbyhu2000 added good first issue Good for newcomers dependencies Pull requests that update a dependency file technical debt If not paid, jeapardizes long-term success and maintainability of the repository. labels Mar 22, 2023
@ltwmori
Copy link

ltwmori commented Mar 23, 2023

I would like to work on this issue.

I have researched potential alternatives and compiled a list for your consideration:

  1. https://github.com/MikeMcl/bignumber.js/
  2. https://github.com/MikeMcl/decimal.js/
  3. https://mathjs.org/
  4. http://numeraljs.com/

Each of these libraries is lightweight, but they may offer varying features. To make an informed decision, it would be helpful to understand the primary purpose and the types of calculations you frequently perform. Could you please leave details about it here?

@abbyhu2000
Copy link
Member Author

@ltwmori Thank you for the reply! We have created a research sub task of this meta issue, and the research sub-task asks to research the usage of TinyMath library in the repo and then propose the best option for its replacement based on the usage. Do you want to pick up that task and document your research there? Here is the link #3656 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants