[BUG] The order of the options loaded from config/node.options and NODE_OPTIONS differs between Windows and non-Windows

[AMoo-Miki]

Describe the bug

On Windows

OpenSearch-Dashboards/src/dev/build/tasks/bin/scripts/opensearch-dashboards.bat

Lines 22 to 33 in 5af9a43

	IF EXIST "%CONFIG_DIR%\node.options" (
	for /F "eol=# tokens=*" %%i in (%CONFIG_DIR%\node.options) do (
	If [!NODE_OPTIONS!] == [] (
	set "NODE_OPTIONS=%%i"
	) Else (
	set "NODE_OPTIONS=!NODE_OPTIONS! %%i"
	)
	)
	)
	:: Include pre-defined node option
	set "NODE_OPTIONS=--no-warnings --max-http-header-size=65536 %NODE_OPTIONS%"

On Windows, when opensearch-dashboards.bat is called, the options read in from config/node.options are appended to any NODE_OPTIONS that might have existed.

On others

OpenSearch-Dashboards/src/dev/build/tasks/bin/scripts/opensearch-dashboards

Lines 42 to 46 in 5af9a43

	if [ -f "${CONFIG_DIR}/node.options" ]; then
	OSD_NODE_OPTS="$(grep -v ^# < ${CONFIG_DIR}/node.options | xargs)"
	fi
	NODE_OPTIONS="--no-warnings --max-http-header-size=65536 $OSD_NODE_OPTS $NODE_OPTIONS" NODE_ENV=production exec "${NODE}" "${DIR}/src/cli/dist" ${@}

When opensearch-dashboards is called, the options read in from config/node.options are passed in and then NODE_OPTIONS is appended.

The difference is that on Windows, config/node.options override NODE_OPTIONS.

[kavilla]

Removing untriaged label as by definition since it is opened by a maintainer.