Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flakey link for datasource plugin tests #3075

Closed
ashwin-pc opened this issue Dec 13, 2022 · 3 comments
Closed

[BUG] Flakey link for datasource plugin tests #3075

ashwin-pc opened this issue Dec 13, 2022 · 3 comments
Assignees
Labels
bug Something isn't working ci help wanted Community development is encouraged multiple datasource multiple datasource project

Comments

@ashwin-pc
Copy link
Member

Describe the bug

We have 2 instances of http://datasource.com that points to a misconfigured url. When our lychee link checker runs during CI/CD, the check fails when this link is not reachable

To Reproduce
The issue is intermittent so here is a reference failure

https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/3653727844/jobs/6173497842

Expected behavior
The link should point to one of the excluded urls e.g. example.com or this domain should be added to the excluded domains. I propose the former since we already have an exhaustive list of excluded URLs ant these 2 use cases dont seem to justify the need for another one.

OpenSearch Version
3.0

Dashboards Version
3.0

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

@ashwin-pc ashwin-pc added bug Something isn't working multiple datasource multiple datasource project labels Dec 13, 2022
@joshuarrrr joshuarrrr added ci help wanted Community development is encouraged labels Dec 13, 2022
@zhongnansu
Copy link
Member

Found lychee exclude list from https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/TESTING.md#additional-checks

Thanks for submitting the issue. I wasn't aware of this during development tho, maybe like you said, it's flaky. Anyway, we'll fix it following best practice
@ashwin-pc

@ashwin-pc
Copy link
Member Author

No worries. Created the issue for tracking purposes since I saw that a lot of tests were having to be rerun because of it. That website will also be getting a lot of traffic from our CI workflows lol.

@ashwin-pc
Copy link
Member Author

@zhongnansu can we close this issue now that those links are fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci help wanted Community development is encouraged multiple datasource multiple datasource project
Projects
None yet
Development

No branches or pull requests

3 participants