Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD]Add support for opensearch legacy client for data source #2133

Closed
Tracked by #2003
zhongnansu opened this issue Aug 12, 2022 · 0 comments
Closed
Tracked by #2003

[MD]Add support for opensearch legacy client for data source #2133

zhongnansu opened this issue Aug 12, 2022 · 0 comments
Assignees
Labels
multiple datasource multiple datasource project

Comments

@zhongnansu
Copy link
Member

zhongnansu commented Aug 12, 2022

Need to do most things similar to opensearch data source client. Register interface, create route context, etc

By adding support for legacy client, I assume the route context for data source will look like this

datasource: {
  getClient:(id) => Promise<OpenSearchClient>
  legacy: {
    getClient: (id) => Promise<OpenSearchLegacyClient>
  }
}

Ref

Legacy Elasticsearch Client: https://www.elastic.co/guide/en/elasticsearch/client/elasticsearch-js/16.x/index.html

Legacy Client lib is doesn't support chilld() option. To avoid re-creating lots of client objects for the same endpoint. Re-use is done by passing auth to the clientParams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple datasource multiple datasource project
Projects
None yet
Development

No branches or pull requests

1 participant